[webkit-dev] unwritten rules of webkit style

[Darin Fisher]

GCC will complain (maybe only a warning?) if C++ files don't end in a
newline.-Darin

On Thu, Sep 3, 2009 at 1:03 PM, Gavin Barraclough <barraclough at apple.com>wrote:

> I believe the C spec requires that files end in a newline, though I
> couldn't comment on the c++ spec.  Possibly redundant to list this as WebKit
> style issue, if required by the language?
> G.
>
> On Sep 3, 2009, at 10:11 AM, Darin Adler wrote:
>
> On Sep 2, 2009, at 11:18 PM, Brent Fulgham wrote:
>
> On Sep 2, 2009, at 9:46 AM, Peter Kasting wrote:
>
> *Misc*
>> Files who should end with newlines.
>>
>
> s/who//.  In fact it might be clearer to say "Files should end with a
> trailing newline".
>
>
> I always follow this rule, but I don't remember why it came to exist.  Is
> this convention needed for source control or something?
>
>
> It’s not needed for anything. Tools like diff produce slightly unpleasant
> output for files that don’t end in newlines, so we include them.
>
>     -- Darin
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20090903/7525fd88/attachment.html>