[webkit-dev] Testing harness for Geolocation

[Andrei Popescu]

Hi Adam,

On Wed, Sep 2, 2009 at 2:59 PM, Adam Barth<abarth at webkit.org> wrote:
> Improvements to the geolocation feature have stalled out because we
> don't have a way to test these patches.  It seems the existing
> geolocation feature has been implemented without testing.  (Boo!)
>
> Testing geolocation seems different than testing other WebKit features
> because geolocation lives in WebCore/platform.  One approach is to
> create a fake (or mock) geolocation service that DRT can control.
> This has been tried a couple of times:
>
> https://bugs.webkit.org/show_bug.cgi?id=21717
> https://bugs.webkit.org/show_bug.cgi?id=28264
>

The approach taken in 28264 uses a static factory method for creating
GeolocationService instances. It also allows DRT to set the specific
factory method that the Geolocation framework will use to one that
creates mock GeolocationService instances. The layout tests can then
use the layoutTestController to configure the mock GeolocationService
as needed. This seems reasonable to me.

Thanks,
Andrei