[webkit-dev] layout test expectation files without tests
Darin Adler
darin at apple.com
Wed Oct 21 07:49:08 PDT 2009
On Oct 21, 2009, at 2:17 AM, Shinichiro Hamaji wrote:
> However, there are some cases in which people forgot to add test
> files.
Thanks for tackling this!
> - fast/dynamic/8952-reduction
> author: darin
> trac: http://trac.webkit.org/changeset/15459
> comment: now the png file is in platform/mac
In this case, I believe what actually happened (3 years ago! it's hard
to remember) was that my test was originally named 8952-reduction in
my local directory and I renamed it to move-node-with-selection before
checking in, but forgot to rename the PNG file.
We should definitely removeLayoutTests/fast/dynamic/8952-reduction-
expected.png -- there is no reason to keep it around. I did not forget
to add a test file in this case.
-- Darin
More information about the webkit-dev
mailing list