[webkit-dev] Runtime setting for incomplete features

Darin Fisher darin at chromium.org
Mon Oct 5 22:13:58 PDT 2009

I think we should enable Web Sockets in the Chromium Test Shell so that we
can exercise all of the layout tests.  (For those not familiar, the Chromium
Test Shell is like DumpRenderTree, but it lives in the Chromium repository.)
I'd imagine that we'd want to enable it in DRT for similar reasons.  I'm not
sure if it is ready to be enabled in WebKit nightlies.  I guess what we are
hearing is that it is.


On Mon, Oct 5, 2009 at 10:05 PM, Fumitoshi Ukai (鵜飼文敏) <ukai at google.com>wrote:

> It is requested to be turned on at the beginning of Web Sockets
> implementation so that it will be tested as it is brought up.
> https://bugs.webkit.org/show_bug.cgi?id=27206
> Is is ok to turn off by default from this point of view?
> On Tue, Oct 6, 2009 at 1:57 PM, Darin Fisher <darin at chromium.org> wrote:
>> On Mon, Oct 5, 2009 at 9:54 PM, Mark Rowe <mrowe at apple.com> wrote:
>>> On 2009-10-05, at 21:48, Darin Fisher wrote:
>>>  It is a matter of our process that we do not change the configuration
>>>> when promoting builds.  The bits that passed the test get promoted.
>>>> I'm happy to absorb this cost in the V8 bindings.  I don't think it is
>>>> important to solve this problem for the JSC bindings since there is not a
>>>> consumer that yet needs the same.
>>> The present state of Web Sockets is that they're compiled in on Mac OS X
>>> but disabled via the runtime setting.  This leads to them being detectable
>>> in the manner Sam mentioned.  Either the compile-time setting needs to be
>>> fixed for Mac OS X or the runtime code fixed so that the feature is not
>>> detectable when disabled.  I assume that we want regression testing of the
>>> feature so disabling it at compile time does not seem like the best idea.  I
>>> guess it comes down to whether or not it's in good enough shape to be useful
>>> to web sites at this time.
>>> - Mark
>> Agreed.  As usual, I think each port should be able to choose when to
>> expose the feature.
>> -Darin
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20091005/eb9411b5/attachment.html>

More information about the webkit-dev mailing list