[webkit-dev] [webkit-changes] [50959] trunk/WebKitTools

[Kenneth Christiansen]

FYI this in not just related to Qt, as at least both win and mac have
similar code.

Kenneth

On Fri, Nov 13, 2009 at 5:34 PM, Alexey Proskuryakov <ap at webkit.org> wrote:

>
> I'm not sure if this is a great approach. Previously, people with other
> default locales exercised code paths that aren't normally taken on U.S.
> systems, and thus could catch problems affecting shipping products early.
>
> It is beneficial that DRT results get more predictable, but tests are most
> useful when they fail, not when they pass :)
>
> - WBR, Alexey Proskuryakov
>
> 13.11.2009, в 12:04, kenneth at webkit.org написал(а):
>
> Revision50959 <http://trac.webkit.org/projects/webkit/changeset/50959>
> Authorkenneth at webkit.orgDate2009-11-13 12:04:24 -0800 (Fri, 13 Nov 2009)Log
> Message
>
> Set the locale to C and not to the current one in use on the system.
>
> Reviewed by Simon Hausmann.
>
> * DumpRenderTree/qt/DumpRenderTree.cpp:
> (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
>
> Modified Paths
>
>    - trunk/WebKitTools/ChangeLog<#124ef40dcff4f255_trunkWebKitToolsChangeLog>
>    - trunk/WebKitTools/DumpRenderTree/qt/DumpRenderTree.cpp<#124ef40dcff4f255_trunkWebKitToolsDumpRenderTreeqtDumpRenderTreecpp>
>
> Diff
> Modified: trunk/WebKitTools/ChangeLog (50958 => 50959)
>
> --- trunk/WebKitTools/ChangeLog	2009-11-13 19:56:43 UTC (rev 50958)
> +++ trunk/WebKitTools/ChangeLog	2009-11-13 20:04:24 UTC (rev 50959)@@ -1,3 +1,12 @@+2009-11-13  Kenneth Rohde Christiansen  <kenneth at webkit.org>
> +
> +        Reviewed by Simon Hausmann.
> +
> +        Set the locale to C and not to the current one in use on the system.
> +
> +        * DumpRenderTree/qt/DumpRenderTree.cpp:
> +        (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
> + 2009-11-13  Adam Roben  <aroben at apple.com>          Finish replacing worldIDs with world objects
>
> Modified: trunk/WebKitTools/DumpRenderTree/qt/DumpRenderTree.cpp (50958 =>
> 50959)
>
> --- trunk/WebKitTools/DumpRenderTree/qt/DumpRenderTree.cpp	2009-11-13 19:56:43 UTC (rev 50958)
> +++ trunk/WebKitTools/DumpRenderTree/qt/DumpRenderTree.cpp	2009-11-13 20:04:24 UTC (rev 50959)@@ -304,8 +304,8 @@      m_page->undoStack()->clear(); -    QLocale qlocale;
> -    QLocale::setDefault(qlocale);+    QLocale::setDefault(QLocale::c());
> +    setlocale(LC_ALL, ""); }  void DumpRenderTree::open(const QUrl& aurl)
>
> _______________________________________________
> webkit-changes mailing list
> webkit-changes at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
>
>
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>


-- 
Kenneth Rohde Christiansen
Technical Lead / Software Engineer
Qt Labs Americas, Nokia Technology Institute, INdT
Phone  +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20091113/14c6cdc6/attachment.html>