[webkit-dev] Proposal for a new way to handle porting #ifdefs

David Hyatt hyatt at apple.com
Sun May 24 23:17:26 PDT 2009

On May 25, 2009, at 12:51 AM, Peter Kasting wrote:

> I would prefer to optimize for reading the code for my port, which  
> generally means as few #ifdefs as possible, and pushing as much  
> logic into the build system as possible (by including or not  
> including various files).  It implies things like preferring per- 
> port subclasses to port-specific members in the parent class,  
> preferring to not include files rather than #ifdef their contents  
> away... basically, the opposite of all the decisions WebKit looks to  
> have taken :D

Can you cite a particular class as an example?  I don't think we have  
any aversion to using per-port subclasses as long as we aren't  
incurring a vtable cost and as long as that class has no subclasses  

(hyatt at apple.com)

More information about the webkit-dev mailing list