[webkit-dev] Proposal for a new way to handle porting #ifdefs

[Maciej Stachowiak]

On May 23, 2009, at 9:38 AM, David Kilzer wrote:

> Another aspect of this proposal is how to handle source files that  
> have #if ENABLE(FEATURE)/#endif guards around all of their source  
> code, for example:
>
> Bug 25756: Explicit guards for ENABLE_GEOLOCATION
> https://bugs.webkit.org/show_bug.cgi?id=25756
>
> There are essentially two options here:
>
> 1. Add #if/#endif guards to entire source files, but include every  
> file in every build system.
>
> 2. Make each build system smart enough to exclude source files that  
> implement a feature, thus pushing the policy decision down (up?)  
> into the build system (which is where most of the decisions are made  
> today anyway).
>
> I think #2 is a much cleaner way to handle this since it removes  
> clutter from the code (at the cost of duplicating knowledge of which  
> files go with with features into each build system).
>
> Does anyone else have an opinion on this?


I know there is a potential compile time tradeoff, but in some ways it  
would be nicer if all build systems built the same set of files, and  
we ifdef'd the contents. That would put the policy decisions all in  
one place (the port header).

Regards,
Maciej

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20090524/37239fb2/attachment.html>