[webkit-dev] Review Queue

Maciej Stachowiak mjs at apple.com
Thu May 21 20:22:29 PDT 2009

On May 21, 2009, at 7:57 PM, Eric Seidel wrote:

> I think it's better to get things out of the queue then to leave  
> them rot.

But it's not the patch submitter's fault if the reviewers have been  
delinquent in review. And making them resubmit the same patch after a  
blanket r- is useless busywork. Per our policy you shouldn't mark a  
patch r- unless you are either requesting revisions or rejecting the  
whole concept of the patch <http://webkit.org/coding/ 
contributing.html>. So if you r-'d any patches without giving review  
comments, please restore them.


> Your review are most welcome. :)
> -eric
> On Fri, May 22, 2009 at 12:48 PM, Maciej Stachowiak <mjs at apple.com>  
> wrote:
>> On May 21, 2009, at 7:27 PM, Eric Seidel wrote:
>>> Our review process seems to be failing.  As a reviewer, let me  
>>> extend
>>> my apologies to the WebKit community as I am part of this failure.
>>> We have over 100 patches in the review queue at the moment:
>>> http://webkit.org/pending-review
>>> I've started going through the list and reviewing what patches I  
>>> can.
>>> I'm also marking r- all patches I can't review which have had no
>>> comments in the last 2 weeks.
>> While it's great to get more reviews done (and I encourage other  
>> reviewers
>> to get cracking as well), I don't think it's appropriate to r-  
>> patches that
>> you don't know how to review, simply because no one else has  
>> reviewed them
>> yet. It is better to have an honest backlog than to sweep things  
>> under the
>> carpet.
>> Regards,
>> Maciej

More information about the webkit-dev mailing list