[webkit-dev] cti_op_call_ArityCheck question

[Toshiyasu Morita]

Thanks guys.

One request - please write more comments in the code to clarify situations like this.

Toshi

--- On Thu, 6/4/09, Darin Adler <darin at apple.com> wrote:

From: Darin Adler <darin at apple.com>
Subject: Re: [webkit-dev] cti_op_call_ArityCheck question
To: "Toshiyasu Morita" <tm_webkit at yahoo.com>
Cc: webkit-dev at lists.webkit.org
Date: Thursday, June 4, 2009, 8:54 PM

On Jun 4, 2009, at 1:50 PM, Toshiyasu Morita wrote:

> I don't understand this code in JITStubs::cti_op_call_arityCheck():
> 
>     ASSERT(argCount != newCodeBlock->m_numParameters);
> 
> It's ensuring that the argument count does not equal the number of parameters expected by the newCodeBlock. I could understand if it was ensuring the argCount was the same, but why different?

This slower code path must only be used when the number of parameters is not equal. If it was used when the number of parameters was equal, it would be a performance bug.

    -- Darin




      
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20090604/cd3baf5a/attachment.html>