[webkit-dev] Towards a commit-queue

Adam Barth abarth at webkit.org
Fri Jul 31 23:40:16 PDT 2009

I've been experimenting with a wrapper for bugzilla-tool that runs in
a loop and tries to land patches [1].  Ideally, there would be enough
information in Bugzilla so I could kick off this script and make tea
while it does its thing.  However, deciding whether a bug with an r+
patch is ready to be landed requires human intervention.

I went through the queue tonight and manually marked the bugs as
commit-ready by adding [commit+] to their titles.  This worked well,
except that it made the bug titles ugly.  I think a better solution is
to have flag analogous to r+ which is commit+.  The flag means "I
certify that this patch is ready to be landed according to WebKit
process."  Unlike r+, this flag would be settable by any committer
because it is the moral equivalent of typing "svn commit".  In rare
cases, such as unreviewed build fixes, a patch could have commit+
without an r+.

In future, future land when we have a working commit queue, the actual
"svn commit" command might be run by a bot instead of a human.


[1] You can see my progress here: https://bugs.webkit.org/show_bug.cgi?id=27918

More information about the webkit-dev mailing list