[webkit-dev] possible wrong implementation visible_units.cpp at logicalStartOfLine

tonikitoo (Antonio Gomes) tonikitoo at gmail.com
Fri Jul 10 12:49:35 PDT 2009


> honorEditableBoundaryAtOrAfter does check whether the visPos is null or not,
> and if it's null, then it returns the original visible position, so it's
> harmless (i.e. does not crash or has a side-effect).  But I'm not sure what
> the caller of logicalStartOfLine is expecting; maybe we're supposed to do
> something in the case visible position was null.  But assuming that the
> original is correct, we don't need that if statement at all.

Exactly , I am trying to understand from the equivalent
logicalEndOfLine implementation what a null-check there is supposed to
prevent here ... (so at first glance i am supposing it was *not* a
typo in the code, but as you said it could had been)

> Did you file a bug for it?
> Ryosuke

just did: https://bugs.webkit.org/show_bug.cgi?id=27154

--Antonio Gomes

More information about the webkit-dev mailing list