[webkit-dev] possible wrong implementation visible_units.cpp at logicalStartOfLine
tonikitoo (Antonio Gomes)
tonikitoo at gmail.com
Thu Jul 9 13:10:39 PDT 2009
Hi,
trying to understand this part of the webcore code, I faced a possibly
wrong impl:
(...)
VisiblePosition logicalStartOfLine(const VisiblePosition& c)
{
VisiblePosition visPos = logicalStartPositionForLine(c);
if (visPos.isNull())
return c.honorEditableBoundaryAtOrAfter(visPos);
return c.honorEditableBoundaryAtOrAfter(visPos);
}
(...)
note that "c.honorEditableBoundaryAtOrAfter(visPos);" will be
executed regardless visPos being null or not. thoughts ?
commit : r43032
--
--Antonio Gomes
More information about the webkit-dev
mailing list