[webkit-dev] Changes to prepare-ChangeLog

[David Kilzer]

On Thursday, July 9, 2009 11:06:58 AM, Maciej Stachowiak wrote:

>On Jul 9, 2009, at 4:33 AM, David Kilzer wrote:
>
>>* What does the format look like for bugs with multiple URL
>>links, e.g., to <rdar://problem/NNNNNNN> or to 
>><http://crbug.com/NNNNN>?  (The title should not have to be
>>repeated--you should be fixing the same issue for all of them.)
>
>I could think of two reasonable options?
>
>     <http://webkit.org/b/27098><rdar://problem/12345> Make prepare-ChangeLog less shouty
>     Reviewed by Mark Rowe.
>
>
>     <http://webkit.org/b/27098> Make prepare-ChangeLog less shouty
>     <rdar://problem/7123456> 
>     Reviewed by Mark Rowe.
>
>Preferences?


#2 please.

>>* Is the "Reviewed by" line going to have a blank line above it?
>>  (I think it should, but I could be persuaded otherwise.)

>
>I don't think it should, if it's one of two special lines at the
>top. Otherwise the whole ChangeLog entry looks double-spaced and
>gets harder to read.


Yeah, I've noticed that.

>>And from The-World-is-Not-Enough Department:
>>
>>* The commit-log-editor should be smart about condensing
>>duplicate content after the date-name-email lines for each
>>ChangeLog entry, and it should move those lines to the top of
>>the commit message.  (This also makes git users happy since the
>>first line would be the bug URL and description, making
>>"git log --oneline" more useful.)
>
>I'm not sure I understand this suggestion.


An illustrated example of pulling common lines out of each subsection (with double-spacing):

http://trac.webkit.org/changeset/44095
http://trac.webkit.org/changeset/44096

Dave