[webkit-dev] Changes to prepare-ChangeLog

Peter Kasting pkasting at google.com
Fri Jul 3 10:24:54 PDT 2009


Since this seems to have become the new bikeshed, I'll chime in with my
color preference:
----

Reviewed by John Smith (jsmith at webkit.org)

https://bugs.webkit.org/show_bug.cgi?id=123456
Fix WebKit being not awesome enough.  Make five files more awesome.

----

FWIW, I agree with those who desire to ditch the ChangeLog.  WebKit is the
only project I've worked on that does such a thing, and I have never gotten
any benefit out of it, while I've gotten lots of headache (merge conflicts
especially).  On Chromium, patches are given a detailed ChangeLog-esque
description which is visible in the review tool and becomes the commit log
message as well (which links back to the review URL, and is also auto-pasted
into the original bug report).  This way from any of (bug system, commit
logs, review system) you can find information about a particular patch or
search for patches matching some comment.  This turns out to work quite well
in practice.  In WebKit I try to give my patches these sorts of comments
when I post them for review, but duplicating info between the ChangeLog and
the review comments always makes me write less than I otherwise would, and
review comments tend to get buried in the sea of noise from bugzilla.

PK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20090703/5adea3fa/attachment.html>


More information about the webkit-dev mailing list