[webkit-dev] Changes to prepare-ChangeLog

Maciej Stachowiak mjs at apple.com
Thu Jul 2 13:44:22 PDT 2009

On Jul 2, 2009, at 11:22 AM, Timothy Hatcher wrote:

> I also agree and that is the style I use.

I've always kept the "Reviewed by" on top, to me it logically goes  
with the date/author line. I don't mind doing it the other way as long  
as prepare-ChangeLog helps me. In the future maybe we could consider  
putting it in the dateline:

2009-06-30  Maciej Stachowiak  <mjs at apple.com>  revewied by Sam Weinig

That way all the blame goes in one place. :-)

  - Maciej

> On Jul 2, 2009, at 7:05 AM, Adam Roben wrote:
>>> - I generally move the "Reviewed by" line after the bug number/ 
>>> description/URL.  When you're reading a ChangeLog entry/commit  
>>> message (especially an older one), it's generally much more  
>>> interesting which bug is being fixed rather than knowing who  
>>> reviewed it.  (Also, putting the bug description first makes git's  
>>> one-line description of each commit much more useful than either  
>>> having a list of dates and the person who wrote the patch or  
>>> having a list of patch reviewers.)
>> I agree with Dave on all three points. git users gotta stick  
>> together.
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20090702/7acaedab/attachment.html>

More information about the webkit-dev mailing list