[webkit-dev] Curl Cookie Handling

[Kevin Ollivier]

Hi Julien,

On Feb 9, 2009, at 7:23 AM, Julien Chaffraix wrote:

> Hi,
>
>> I have Integrated the patch given in
>> https://bugs.webkit.org/show_bug.cgi?id=14730  on webkit r36766 with
>> additions on SQLITE db calls
>
> As you have seen this patch is not integrated and is a year old. As a
> result, it may have rotten (the code has changed and some assertions I
> made are not true anymore) and it was not tested much outside myself
> and a few people like you. So it is likely that there are some bugs
> (one was already mentioned on the bugzilla).

Is this patch still valid, i.e. not made obsolete by another approach?  
Also, was it a complete patch (sans any bugs, of course) for cookie  
support using SQLite? I could only test it using wx right now but I  
would definitely be interested in using the SQLite approach.

I know someone a while back proposed a strategy for dealing with port  
enhancements that end up bit rotting in the review tree, whatever  
happened to that? Sometimes new feature patches cannot be broken down  
into smaller pieces, and I realize large patches tend to be  
intimidating especially to people who can't test them themselves, but  
there has to be some strategy for dealing with that so that important  
new stuff doesn't just sit in a patch tracker for months or years...

Regards,

Kevin

>
>> The patch does not work on www.facebook.com and results an  
>> inconsistent
>> crashes / memory corruptions. Here is the snapshot of what valgrind  
>> has:
> [removed the backtrace]
>
> After a quick look at the code, it is likely that you are manipulating
> a deleted pointer. The cookie is taken directly from a cookieMap,
> which means that the cookieMap is not updated at some point when we
> release one of its pointer. However without further information, I
> cannot say more and you will have to debug yourself. Have you tried a
> DEBUG build as there are some assertions that could catch it earlier
> and help you tie the crash to one area of code? Also look at the
> different LOG information as they can help you.
>
> Regards,
> Julien
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev