[webkit-dev] Curl Cookie Handling

[mwas]

Hi,

I have Integrated the patch given in
https://bugs.webkit.org/show_bug.cgi?id=14730  on webkit r36766 with
additions on SQLITE db calls

The patch does not work on www.facebook.com and results an inconsistent
crashes / memory corruptions. Here is the snapshot of what valgrind has:

 833 ==30082== by 0x4898C94:
JSC::JSActivation::argumentsGetter(JSC::ExecState*, JSC::Identifier const&,
JSC::PropertySl ot const&) (in /usr/local/lib/libwebkit-1.0.so.1.0.0)
 834 ==30082== by 0x487BA26: JSC::resolve(JSC::ExecState*,
JSC::Instruction*, JSC::Register*, JSC::ScopeChainNode*, JSC: :CodeBlock*,
JSC::JSValue*&) (in /usr/local/lib/libwebkit-1.0.so.1.0.0)
 835 ==30082== by 0x487FF2C:
JSC::Machine::privateExecute(JSC::Machine::ExecutionFlag, JSC::ExecState*,
JSC::RegisterFil e*, JSC::Register*, JSC::ScopeChainNode*, JSC::CodeBlock*,
JSC::JSValue**) (in /usr/local/lib/libwebkit-1.0.so.1.0.0)
 836 ==30082== by 0x4889889: JSC::Machine::execute(JSC::FunctionBodyNode*,
JSC::ExecState*, JSC::JSFunction*, JSC::JSObj ect*, JSC::ArgList const&,
JSC::ScopeChainNode*, JSC::JSValue**) (in
/usr/local/lib/libwebkit-1.0.so.1.0.0)
 837 ==30082== by 0x47EFB10: JSC::functionProtoFuncApply(JSC::ExecState*,
JSC::JSObject*, JSC::JSValue*, JSC::ArgList co nst&) (in
/usr/local/lib/libwebkit-1.0.so.1.0.0)
 838 ==30082== by 0x4881C4A:
JSC::Machine::privateExecute(JSC::Machine::ExecutionFlag, JSC::ExecState*,
JSC::RegisterFil e*, JSC::Register*, JSC::ScopeChainNode*, JSC::CodeBlock*,
JSC::JSValue**) (in /usr/local/lib/libwebkit-1.0.so.1.0.0)
 839 ==30082== by 0x4889889: JSC::Machine::execute(JSC::FunctionBodyNode*,
JSC::ExecState*, JSC::JSFunction*, JSC::JSObj ect*, JSC::ArgList const&,
JSC::ScopeChainNode*, JSC::JSValue**) (in
/usr/local/lib/libwebkit-1.0.so.1.0.0)
 840 ==30082== by 0x47EFB10: JSC::functionProtoFuncApply(JSC::ExecState*,
JSC::JSObject*, JSC::JSValue*, JSC::ArgList co nst&) (in
/usr/local/lib/libwebkit-1.0.so.1.0.0)
 841 ==30082==
 842 ==30082== Invalid read of size 4
 845 ==30082== by 0x44CCEF2:
WebCore::CookieManager::removeCookieFromDatabase(WebCore::Cookie const*) (in
/usr/local/lib /libwebkit-1.0.so.1.0.0)
 846 ==30082== by 0x44CDECA:
WebCore::CookieManager::getCookies(WebCore::KURL const&) (in /usr/local/lib/
libwebkit-1.0.so .1.0.0)
 847 ==30082== by 0x44CA5C5: WebCore::cookies(WebCore::Document const*,
WebCore::KURL const&) (in /usr/local/lib/libwebk it-1.0.so.1.0.0)
 848 ==30082== by 0x41EBDB2: WebCore::Document::cookie() const (in
/usr/local/lib/libwebkit-1.0.so.1.0.0)
 849 ==30082== by 0x4655903:
WebCore::JSDocument::getValueProperty(JSC::ExecState*, int) const (in
/usr/local/lib/libweb kit-1.0.so.1.0.0)
 850 ==30082== by 0x48806F0:
JSC::Machine::privateExecute(JSC::Machine::ExecutionFlag, JSC::ExecState*,
JSC::RegisterFil e*, JSC::Register*, JSC::ScopeChainNode*, JSC::CodeBlock*,
JSC::JSValue**) (in /usr/local/lib/libwebkit-1.0.so.1.0.0)
 851 ==30082== by 0x4889889: JSC::Machine::execute(JSC::FunctionBodyNode*,
JSC::ExecState*, JSC::JSFunction*, JSC::JSObj ect*, JSC::ArgList const&,
JSC::ScopeChainNode*, JSC::JSValue**) (in
/usr/local/lib/libwebkit-1.0.so.1.0.0)
 852 ==30082== by 0x47EFB10: JSC::functionProtoFuncApply(JSC::ExecState*,
JSC::JSObject*, JSC::JSValue*, JSC::ArgList co nst&) (in
/usr/local/lib/libwebkit-1.0.so.1.0.0)
 853 ==30082== by 0x4881C4A:
JSC::Machine::privateExecute(JSC::Machine::ExecutionFlag, JSC::ExecState*,
JSC::RegisterFil e*, JSC::Register*, JSC::ScopeChainNode*, JSC::CodeBlock*,
JSC::JSValue**) (in /usr/local/lib/libwebkit-1.0.so.1.0.0)
 854 ==30082== by 0x4889889: JSC::Machine::execute(JSC::FunctionBodyNode*,
JSC::ExecState*, JSC::JSFunction*, JSC::JSObj ect*, JSC::ArgList const&,
JSC::ScopeChainNode*, JSC::JSValue**) (in
/usr/local/lib/libwebkit-1.0.so.1.0.0)
 855 ==30082== Address 0xe is not stack'd, malloc'd or (recently) free'd
 demangling stack gives the following

WebCore::String::append(WebCore::String const&)
free+332
WebCore::operator+(WebCore::String const&, WebCore::String const&)

WebCore::CookieManager::getCookie(WebCore::KURL const&)

Pls. suggest any way out.

Thanks

mwas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20090209/1d501321/attachment.html>