[webkit-dev] Upstreaming IDL changes for the V8 bindings

Darin Fisher darin at chromium.org
Wed Feb 4 08:59:08 PST 2009


Yup, that was my plan.  Custom will be respected by both code generators.
-Darin


On Tue, Feb 3, 2009 at 4:06 PM, Dimitri Glazkov <dglazkov at google.com> wrote:

> To minimize the span of the changes, let's keep Custom as well, which
> in this context should mean -- Custom for all platforms. WDYT?
>
> :DG<
>
> On Mon, Feb 2, 2009 at 5:16 PM, Geoffrey Garen <ggaren at apple.com> wrote:
> >> I was about to upstream some patches that add #ifdefs to the WebCore IDL
> >> files.  In many cases, the only delta is the removal of the Custom
> >> attribute.  Eric Seidel pointed out that it might be better to rename
> those
> >> usages of Custom to JSCCustom to avoid #ifdefs.
> >>
> >> This change would avoid #ifdefs in Node.idl, SVGPointList.idl,
> >> SVGPathSegList.idl, and SVGTransformList.idl.  I would similarly like to
> add
> >> a V8Custom attribute for use in the cases where the V8 bindings need
> custom
> >> code for an attribute or method.  That would allow us to avoid #ifdefs
> in
> >> Document.idl.
> >>
> >> Does this sound like a good idea?
> >
> > I think so.
> >
> > Geoff
> > _______________________________________________
> > webkit-dev mailing list
> > webkit-dev at lists.webkit.org
> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20090204/69d7568a/attachment.html>


More information about the webkit-dev mailing list