[webkit-dev] SVG Filters

[Nikolas Zimmermann]

Am 04.12.2009 um 20:06 schrieb Maciej Stachowiak:

>
> On Dec 4, 2009, at 11:02 AM, Dirk Schulze wrote:
>
>>> What kinds of tests do we have for the code already? Do we have  
>>> code that tries to exercise edge cases? Do we have a fuzzer of  
>>> some sort?
>>>
>>>   -- Darin
>>
>> Every effect that was implemented has at least one test. They are  
>> mostly
>> simple test cases that just test one effect at once but there are  
>> also
>> more complex tests, to see the behavior on combining different  
>> effects.
>> I try to address the different edge cases of every filter effect  
>> and add
>> more tests if necessary.
>> Mainly effects with pixel manipulation already have more than one  
>> test
>> to target different edge cases.
>
> I think the feature is ready to be enabled by default.
>
> One thing that would strongly increase my confidence in actually  
> shipping it would be some form of fuzz testing. Design review by  
> security experts would also help, but that is hard to arrange.  
> Whereas anyone can write a fuzz tester.

Indeed, fuzz testing sounds fine. Will have a chat with Dirk, in order  
to prepare such a set of testcases. In the meanwhile I'll prepare a  
patch turning SVG filters on!

Have a nice weekend,
Niko