[webkit-dev] namespace indent

[Jeremy Orlow]

Adam's right though: unlike most of the other style changes, if we don't fix
this one all at once, only new files will ever match the style guide.  This
is different than most of the other guidelines where things eventually
converge as people touch lines of the file.

On Tue, Dec 1, 2009 at 3:22 PM, David Levin <levin at chromium.org> wrote:

> 4) (I think it may be possible to) notice that there are other unchanged
> lines that have this problem, and then just not print the error if that
> occurs.
>
> dave
>
>
>
> On Tue, Dec 1, 2009 at 12:42 PM, Adam Barth <abarth at webkit.org> wrote:
>
>> A common "false positive" in the style-queue is as follows:
>>
>> Code inside a namespace should not be indented.  [whitespace/indent] [4]
>>
>> That's because the namespace indent rule is fairly new and its hard to
>> fix without touching the whole file.  I don't think the style-queue
>> should be spamming bugs with non-actionable information.  There seem
>> to be a few choices:
>>
>> 1) Disable this warning because it's not helpful at the moment.
>> 2) Change our code to comply with this style rule (e.g., as we touch
>> files, fix them so that the warning doesn't occur).
>> 3) Change our style guide to match our code.
>>
>> Personally, I'm in favor of (2) because it seems silly to have a rule
>> in our style guide with which we never plan to actually comply.
>>
>> Thoughts?
>>
>> Adam
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20091201/7c9bc6e1/attachment.html>