[webkit-dev] r45939 broke my workflow

[David Kilzer]

On Friday, August 21, 2009 at 1:10:31 PM, Geoffrey Garen wrote:


> r45939 broke my workflow. Here's the related bugzilla bug: 
> https://bugs.webkit.org/show_bug.cgi?id=26999.
> 
> Old "Roll out a patch" workflow:
> 
> cd JavaScriptCore
> svn-create-patch > patch.txt
> svn-unapply patch.txt
> 
> Old "Roll in a patch" workflow:
> 
> cd JavaScriptCore
> svn-apply patch.txt
> 
> These old ways of doing things no longer work because svn-apply and svn-unapply 
> don't match svn-create-patch's new behavior of changing to the WebKit root 
> directory if you're currently working in a WebKit subdirectory.
> [...]
> I tried to ignore this for a while, but it's really causing problems for me and 
> at least one other WebKit developer.
> 
> Should we revert r45939?
> 
> Is there an easy fix to svn-apply and svn-unapply that you can make?


I believe there is an easy fix for this particular workflow, which is to make svn-apply and svn-unapply behave the same way as svn-create-patch.

This will make it slightly harder to apply patches that aren't meant to be applied at the repository root, but we could add a command-line switch to not change directories when applying.  The switch would only be necessary if you're applying such a patch.

IMO, patches that aren't created at the repository root are more confusing to review anyway.

Dave