[webkit-dev] checking style for patches automatically [was: Calling All Reviewers]

[Maciej Stachowiak]

On Aug 7, 2009, at 4:03 PM, David Levin wrote:

> Running check-webkit-style automatically as an fyi -- maybe during  
> prepare-ChangeLog -- would be cool.
>
> Personally, I thought it would be good to let it have a little more  
> time to bake before doing this.

Seems like a good idea to run it in an advisory way. And I agree about  
the bake time.

  - Maciej

>
> dave
>
> On Fri, Aug 7, 2009 at 3:37 PM, Joe Mason  
> <joe.mason at torchmobile.com> wrote:
> Adam Treat wrote:
> On Friday 07 August 2009 05:51:57 pm Eric Seidel wrote:
> We also definitely need to fix our tools to make it impossible to  
> post a
> patch w/o a ChangeLog, and impossible to post a patch that doesn't  
> pass
> check-webkit-style.
>
> This is a bad idea.  check-webkit-style still has false positives  
> and is very new.  It has been designed to never be free of false  
> positives in fact.
>
> Not to mention there will always be places where human judgement  
> overrides the guidelines.
>
>
>
> Joe
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20090807/bcaf41df/attachment.html>