[webkit-dev] WinCE Font work

Dan Bernstein mitz at apple.com
Wed Aug 5 11:13:58 PDT 2009


Today while looking at the patch at <https://bugs.webkit.org/show_bug.cgi?id=28021 
 > I noticed that the WinCE version of FontCustomPlatformData includes  
CachedFont.h and uses CachedFont.

It is incorrect for classes in the platform layer to have any  
knowledge of higher WebCore layers (essentially, anything outside the  
platform hierarchy). In this case, it also necessitated a platform  
difference in the createFontCustomPlatformData call site in  
CachedFont::ensureCustomFontData(), which is how I noticed it.

I think once you should correct this and any other layering violations  
in the WinCE platform layer, and only then submit patches with changes  
to cross-platform code, if any such changes are still deemed  
necessary. I don’t think <https://bugs.webkit.org/show_bug.cgi? 
id=27734> and <https://bugs.webkit.org/show_bug.cgi?id=28021> should  
be reviewed until then.


More information about the webkit-dev mailing list