[webkit-dev] SLL_Pop list is not checked for NULL
Luka Napotnik
luka.napotnik at gmail.com
Mon Aug 3 10:09:01 PDT 2009
Dne 03.08.2009 (pon) ob 09:51 -0700 je Darin Adler zapisal(a):
> On Aug 3, 2009, at 5:00 AM, Luka Napotnik wrote:
>
> > In JavaScriptCore/wtf/FastMalloc.cpp:696
> >
> > The list should be checked for NULL.
>
> No, that’s incorrect. The code is fine as it is. There’s only one
> caller and that caller guarantees that neither list nor *list is 0. Is
> there some reason you think this change is necessary?
Oh didn't trace SLL_Pop() back to Pop() to see the ASSERT(). I was just
walking the source and noticed.
>
> -- Darin
>
Greets,
Luka
More information about the webkit-dev
mailing list