darin at apple.com
Sun Aug 2 02:09:17 PDT 2009
On Aug 2, 2009, at 2:05 AM, Adam Barth wrote:
> In any case:
> I'll have a patch shortly. Please let me know if there are other
> call sites you'd like changed.
Thanks! Once you pointed out this was not due to a recent change, I
had resolved to fix it myself, but I’m glad you’re going to tackle it.
Generally speaking no call site that has a Node* should call
scriptExecutionContext(). So rather than listing the call sites I want
changed, I’d instead suggest that we make Node::scriptExecutionContext
() private and then make sure no Node member functions or members
functions of friend classes call the function.
And the same is true of most other classes derived from EventTarget.
More information about the webkit-dev