[webkit-dev] ［GTK］Scroll deficiency

[Frank Thomsen]

Hi,

I had the same problem as both Xiong and Brent, but none of their fixes seemed to work for me. But commenting out a few lines of code in the following method did the trick for me. I hope it will work for you too, even though it is a quick-and-dirty fix:

void WebView::repaint(const WebCore::IntRect& windowRect, bool contentChanged, bool immediate, bool repaintContentOnly)
{
//    if (!repaintContentOnly) {
        RECT rect = windowRect;
        ::InvalidateRect(m_viewWindow, &rect, false);
//    }
//    if (contentChanged)
        addToDirtyRegion(windowRect);
    if (immediate) {
        if (repaintContentOnly)
            updateBackingStore(core(topLevelFrame())->view());
        else
            ::UpdateWindow(m_viewWindow);
	}
}

Best regards
Frank

-----Original Message-----
From: webkit-dev-bounces at lists.webkit.org [mailto:webkit-dev-bounces at lists.webkit.org] On Behalf Of Brent Fulgham
Sent: 31. marts 2009 01:04
To: xiong
Cc: webkit-dev at lists.webkit.org
Subject: Re: [webkit-dev] ［GTK］Scroll deficiency

Hi Xiong,

Thanks for trying these suggestions.

On Sun, Mar 29, 2009 at 8:24 PM, xiong <browserwk at gmail.com> wrote:
> Brent,
>
> In my platform, all the hack as you metioned are valueless.
>
> Bad news to me.
>
> Now, i only have a clue on cario for the scroll problem.

I think we may have two separate (but perhaps related) bugs, because
the workarounds I described do not help your problem.  Furthermore,
the change you suggested (comment out the "if (contentChanged)" test
in ChromeClient::repaint ()) does not resolve my problem, while it
does fix yours.

Thanks,

-Brent
_______________________________________________
webkit-dev mailing list
webkit-dev at lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev