[webkit-dev] Feature flags and ports

[Amanda Walker]

(points avi at the "some thoughts on platform flags" thread from
yesterday ... :-) )

On Thu, Sep 25, 2008 at 2:29 PM, Avi Drissman <avi at google.com> wrote:
> In WebKit, PLATFORM(MAC) means a lot of things, and one thing in particular
> it means is to use NSURLResponse. I filed
> https://bugs.webkit.org/show_bug.cgi?id=20890 with a patch, and it kicked up
> a storm.
>
> It seemed like there was fundamental disagreement about what the meaning of
> PLATFORM(MAC) really was. Did it mean "use Mac APIs"? Perhaps it's "Apple's
> Mac port".
>
> I'll take my position, that PLATFORM(MAC) means that WebKit should use core
> Mac APIs. Not ones that are replaceable (like NSURL, since we're replacing
> that with our own loaders), but the core ones like Cocoa UI APIs, etc.
> There's a fine line there; after all, anything's replaceable with enough
> effort. That's fine; I'm happy with leaving most things as PLATFORM(MAC) and
> then, if need be, split them off into USE(SOMEFEATURE).
>
> Avi
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>



-- 
--Amanda

"The problem with X is that it's overadequate." --Dennis Ritchie