[webkit-dev] Problem with transparency and webpages withoutbgcolor definition -> Bug?

[Weber, Bernd]

Done.

https://bugs.webkit.org/show_bug.cgi?id=22457

 

 

________________________________

From: webkit-dev-bounces at lists.webkit.org
[mailto:webkit-dev-bounces at lists.webkit.org] On Behalf Of David Kilzer
Sent: Thursday, November 20, 2008 9:23 PM
To: Weber, Bernd
Cc: webkit-dev at lists.webkit.org
Subject: Re: [webkit-dev] Problem with transparency and webpages
withoutbgcolor definition -> Bug?

 

Hi Bernd,

 

Please file a bug on
<https://bugs.webkit.org/enter_bug.cgi?product=WebKit> and attach a
patch for review.  Thanks!

 

Dave

 

 

________________________________

From: "Weber, Bernd" <BWEBE at dolby.com>
To: webkit-dev at lists.webkit.org
Sent: Thursday, November 20, 2008 7:43:26 PM
Subject: [webkit-dev] Problem with transparency and webpages without
bgcolor definition -> Bug?

Hi,

 

I run a GTK webkit here with transparency activated. Now we found when
we load an HTML page that has no bgcolor information, neither as
attribute in the body tag, nor as stylesheet property, then the page
background is set to transparent and not to the default background color
defined in WebCore/page/FrameView.cpp (->m_baseBackgroundColor). This
seems to be because the check in WebCore/rendering/RenderBox.cpp line
835 is wrong. In case of an invalid background color, like in our case,
it shouldn't matter whether transparency is active or not the background
should then always be set to the baseBackgroundColor. I think the
parenthesis' are just set incorrectly here.

 

Should be ->   if (isRoot() && (!bgColor.isValid() || (bgColor.alpha() <
0xFF && !isTransparent))) {

 

 

-Bernd




-----------------------------------------
This message (including any attachments) may contain confidential
information intended for a specific individual and purpose.  If you
are not the intended recipient, delete this message.  If you are
not the intended recipient, disclosing, copying, distributing, or
taking any action based on this message is strictly prohibited.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20081124/7e8e77ea/attachment.html>