[webkit-dev] Best practices for PLATFORM(X) vs. HAVE(X) vs. USE(X) vs. ENABLE(X)? (was: Best practices for USE(X) vs. ENABLE(X)?)

[Maciej Stachowiak]

On Nov 12, 2008, at 2:07 PM, Adam Roben wrote:

>
> On Nov 12, 2008, at 4:57 PM, Darin Adler wrote:
>
>> On Nov 12, 2008, at 1:44 PM, Adam Roben wrote:
>>
>>> I guess while we're at it we might as well clear up the meaning of  
>>> PLATFORM(X) and HAVE(X), as well.
>>
>> I believe PLATFORM is for large scale questions like "What kind of  
>> compiler is this?"
>
> For that specific question we have COMPILER(X). But I think I  
> understand what you're getting at.
>
> It seems to me that we have two conflicting kinds of uses of PLATFORM.
>
> Use 1: Defining whether to use large platform libraries, e.g,  
> PLATFORM(CG), PLATFORM(CF), PLATFORM(CURL)
> Use 2: Defining a whole "port" or "flavor" of WebKit, e.g.,  
> PLATFORM(MAC), PLATFORM(WIN)
>
> It might be beneficial to have separate macros for Use 1 and Use 2.

I think many things about our use of Platform.h macros are messed up,  
and indeed this is one of them. I have a proposal brewing for how to  
do port configuration that I will send to the list soon.

  - Maciej