[webkit-dev] renaming ASSERT macro

Simon Hausmann hausmann at kde.org
Wed Jul 2 01:12:13 PDT 2008

On Wednesday 02 July 2008 09:40:19 Jörg Bornemann wrote:
> Hi Darin,
> Thanks for your detailed comments!
> > Adding <windows.h> to Assertions.h will not cause it to be included in
> > public headers. Assertions.h is not designed to be used in public
> > headers; it's for internal use inside the WebKit project.
> I've just executed the following:
> find . -name '*.h' -exec grep -Hn 'Assertions.h' '{}' \;
> You're sure, that none of the 40+ files, the above call yields, is a
> public header or used inside a public header?
>    But well, if Assertions.h is meant to be part of the private API,
> that particular argument of mine is void. A public header including
> Assertions.h, even an indirect include, should then be considered as bug?

I don't think Assertions.h is used in any public header file. It's for sure 
not the case in the Qt port, and since it includes Platform.h I doubt it 
would work in any public header.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://lists.webkit.org/pipermail/webkit-dev/attachments/20080702/b44624fe/attachment.bin 

More information about the webkit-dev mailing list