[webkit-dev] webkit test suite help

Mark Rowe mrowe at apple.com
Wed Jan 16 21:29:07 PST 2008

On 17/01/2008, at 16:15, syed mehdi wrote:

> first i am cd ing the directory where webkit is present, than i  
> execute WebKitTools/Scripts/run-webkit-tests on terminal.
> i made a few changes in run-webkit-tests and made the default value  
> of $platform as "gtk", also where we are pushing the parameters to  
> build dumptree i made the default push as: push(@args, "--gtk");

Why did you need to modify run-webkit-tests?  As mentioned in my reply  
to your initial email, you can run the tests for Gtk with:

./WebKitTools/Scripts/run-webkit-tests --gtk

Simply setting $platform inside the run-webkit-tests script will not  
affect any code paths that check isGtk(), of which there are many in  
the scripts run-webkit-tests depends on.

Also, the version of run-webkit-tests you provided does not look to be  
based on r29215 like you stated.  It contains code that was removed in  
r27197 and looks to omit many of my changes from r28748, which was the  
initial version of run-webkit-tests in which Gtk would pass any tests.

- Mark

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2413 bytes
Desc: not available
Url : http://lists.webkit.org/pipermail/webkit-dev/attachments/20080117/8d48d246/smime.bin

More information about the webkit-dev mailing list