[webkit-dev] Pulling together on WebKit Mobile

[Adam Roben]

zucker at wake3.com wrote:
>> What sort of errors? link errors?
>>     
>
> As a quick test, I #undef'ed WTF_PLATFORM_CG, WTF_USE_CFNETWORK, and
> WTF_PLATFORM_CF; and instead #define'd WTF_PLATFORM_CAIRO and
> WTF_USE_WININET.
>
> Building WebCore alone resulted in 389 compile errors.
>
> The basic structure of using these #defines seems good.  But apparently,
> when CF, CG, and CFNetwork were added, the previous constructs were badly
> broken.
>   

This isn't too surprising -- code that isn't used quickly goes stale. 
But it should be quite possible to fix!

-Adam

>   
>> On 14/01/2008, at 4:26 PM, zucker at wake3.com wrote:
>>
>>     
>>>> The windows code the depends on apple libraries are either in CG/CF
>>>> specific files,
>>>> or PLATFORM(CG)/PLATFORM(CF).  The expectation would be that you'd be
>>>> adding
>>>> PLATFORM(WINCE) or PLATFORM(GDI) or some such.
>>>>
>>>>         
>>> Agreed.  My point is that if you try to compile now using WININET,
>>> CAIRO,
>>> etc. instead of CG, CF, CN, you get _lots_ of errors.
>>>       
>> What sort of errors? link errors? PLATFORM(QT) can compile on
>> windows, so
>> if PLATFORM(WININET) PLATFORM(CAIRO) fails it implies there is either
>> some
>> code making incorrect assumptions about the PLATFORM, missing file
>> guards,
>> or more likely, unimplemented PLATFORM functionality.
>>
>>     
>>>> The best and easiest way to discuss this would be on IRC in the
>>>> #webkit channel of
>>>> freenode...
>>>>         
>>> Sure, but it seems tough to get a time when everyone interested is on.
>>> Should we set a time to discuss this?
>>>       
>> I think you'd be safe anywhere between 2pm and 10pm PST, although that's
>> only an educated guess based on my recollection of when GTK, QT, and
>> Apple
>> folk are around.
>>
>> --Oliver
>>
>>     
>>> Cheers,
>>> Dan
>>>
>>>       
>>>> On 14/01/2008, at 3:48 PM, zucker at wake3.com wrote:
>>>>         
>>>>> My main concern is to make sure Windows Mobile code is part of the
>>>>> main
>>>>> trunk, and not a side branch.  My recommended first step to make
>>>>> the trunk
>>>>> more Windows Mobile friendly is to update the Windows version to
>>>>> build
>>>>> without requiring proprietary Apple libraries.
>>>>>
>>>>> How does the community feel about this?
>>>>>           
>>>> The windows code the depends on apple libraries are either in CG/CF
>>>> specific files,
>>>> or PLATFORM(CG)/PLATFORM(CF).  The expectation would be that you'd be
>>>> adding
>>>> PLATFORM(WINCE) or PLATFORM(GDI) or some such.
>>>>
>>>> The best and easiest way to discuss this would be on IRC in the
>>>> #webkit channel of
>>>> freenode...
>>>>
>>>> --Oliver
>>>>
>>>>
>>>>         
>>>       
>>     
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-dev
>