[webkit-dev] WebKit/WebKit/win Classes

[Darin Adler]

On Dec 30, 2008, at 3:31 PM, Brent Fulgham wrote:

> I recently proposed a patch
> (https://bugs.webkit.org/show_bug.cgi?id=23027) to the
> Windows-specific WebKit layer (WebKit/WebKit/win), which changed some
> types from CoreGraphics to WebCore/GraphicsContext types.  This was
> rejected because the WebCore classes are apparently not meant to be
> used at the WebKit level.

Yes, WebCore classes are not meant to be used in the interface *to*  
WebKit. They are for use inside WebKit.

> I had believed that the road towards
> using the generic GraphicContext types was acceptable based on these
> earlier discussions, but was apparently mistaken.

The specific issue here is how to make headers that work for external  
clients that are not part of WebKit. WebKit's internal platform- 
configuration macros and platform-independence framework were not  
designed for use in WebKit's external programming interface.

The same issue came up in the past in the context of defining an  
appropriate character type for the JavaScriptCore headers. The JSChar  
type in the JSStringRef.h header has to be defined separately from the  
UChar type that WTF defines for our internal use.

Please take a look at my comments in <https://bugs.webkit.org/show_bug.cgi?id=23027 
 > for some more specifics.

     -- Darin