[webkit-dev] Huge Memory Leak: How to restrict?

[Dhananjoy Chutia]

Hi,
    The statement *d->m_msg = NULL* is removed as
I observed that *m_msg* is g_object_unref ed at

ResourceHandleInternal::~ResourceHandleInternal()
{
    if (m_msg) {
        g_object_unref(m_msg);
        m_msg = 0;
    }
}

but never executed. So, as per my understanding, the statement* d->m_msg =
NULL* is removed. Will it create any new problem? I am new in this area. I
expect your valuable suggestion.

Regards
Dhananjoy


On Fri, Dec 19, 2008 at 8:59 PM, Dhananjoy Chutia <dhanrd at gmail.com> wrote:

> Hi,
>    Thank you for your information. I had done the following modification in
> WebKit-r39293 & observed the VmSize of GtkLauncher for more than 40 minutes
> & found no increase. Please let me know whether my modification is correct
> or not. It is to be noted that WebKit is configured with *--with-target=x11
> --with-http-backend=soup*.
>
>
> diff -pu a/WebCore/platform/network/soup/ResourceHandleSoup.cpp
> b/WebCore/platform/network/soup/ResourceHandleSoup.cpp
> --- a/WebCore/platform/network/soup/ResourceHandleSoup.cpp      2008-12-19
> 20:22:23.000000000 +0530
> +++ b/WebCore/platform/network/soup/ResourceHandleSoup.cpp      2008-12-19
> 20:24:53.000000000 +0530
> @@ -164,7 +164,6 @@ static void finishedCallback(SoupSession
>
>      ResourceHandleInternal* d = handle->getInternal();
>      // The message has been handled.
> -    d->m_msg = NULL;
>
>      ResourceHandleClient* client = handle->client();
>      if (!client)
>
>
> Snap shot of current observation:
> Fri Dec 19 19:56:33 IST 2008
> webkit: VmSize:    57368 kB
> ****************
> Fri Dec 19 19:57:33 IST 2008
> webkit: VmSize:    57368 kB
> ****************
> Fri Dec 19 19:58:33 IST 2008
> webkit: VmSize:    57368 kB
> ****************
> Fri Dec 19 19:59:33 IST 2008
> webkit: VmSize:    57368 kB
>
>
>
> Regards
> Dhananjoy
>
>
>
> On Thu, Dec 18, 2008 at 4:35 PM, Holger Freyther <zecke at selfish.org>wrote:
>
>> On Thursday 18 December 2008 07:02:35 Dhananjoy Chutia wrote:
>> > Hi,
>> >     I had carried out one experiment with GtkLauncher, by loading and
>> > unloading a page at interval of 2 seconds. I observed VmSize of
>> GtkLauncher
>> > at interval of one minute. Memory is increased gradually. Here is my
>> > observation result.
>>
>> Your test is flawed. And i have explained this several times on mails and
>> irc.
>> So here is the deal. I give you information and you contribute back. So no
>> information until I'm certain that you are willing to get results of your
>> findings upstream.
>>
>>
>> z.
>>
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>
>
>
> --
> Dhananjoy
>



-- 
Dhananjoy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20081219/56d1471f/attachment.html>