[webkit-dev] globals and guidelines

[David Kilzer]

And by "a patch" I meant a patch to coding-style.html, not to change every static variable (yet :).

Dave




________________________________
From: David Kilzer <ddkilzer at webkit.org>
To: Cary Clark <caryclark at google.com>
Cc: webkit-dev at lists.webkit.org
Sent: Tuesday, December 9, 2008 12:51:57 PM
Subject: Re: [webkit-dev] globals and guidelines


Hi Cary,

There currently isn't a convention.  It would be great if you filed a bug on <https://bugs.webkit.org/> to update the coding-style guidelines (and provided a patch if you have an opinion on the matter).

Thanks!

Dave




________________________________
From: Cary Clark <caryclark at google.com>
To: webkit-dev at lists.webkit.org
Sent: Tuesday, December 9, 2008 12:46:52 PM
Subject: [webkit-dev] globals and guidelines

Global variables aren't discussed here:

  http://webkit.org/coding/coding-style.html

In sources, I see:
gX.. WebCore/rendering/RenderLayer.h:138:    static const
ScrollAlignment gAlignCenterIfNeeded;
s_x.. WebCore/rendering/RenderObject.h:964:    static bool s_affectsParentBlock;
AxBx.. WebCore/dom/RangeException.h:41:        static const int
RangeExceptionOffset = 200;

Is there one convention for const, and one for non-const? Or none at all?
Thanks
Cary
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20081209/5fa6dfde/attachment.html>