[webkit-dev] _blank hrefs and new windows
Srinivas Rao M Hamse
msrinirao at gmail.com
Wed Apr 16 23:06:20 PDT 2008
Hi David,
Updated https://bugs.webkit.org/show_bug.cgi?id=16562 buglog with my
observations as comments.
regards,
Srinivas Rao. M
On Wed, Apr 16, 2008 at 8:29 PM, David Kilzer <ddkilzer at webkit.org> wrote:
> > is there a way to get this patch working on the latest builds ?
>
> Please add these comments to the bug itself. Perhaps the author of the
> patch
> will revise it for a later revision.
>
> Dave
>
>
> Srinivas Rao M Hamse <msrinirao at gmail.com> wrote:
>
> > Hi David,
> >
> >
> > Have you tried applying the patch to see if it fixes the issue on your
> local
> > > tree?
> >
> >
> > First of all the patch file was not compatible with the latest
> > nightlies(r31848). Hence i manually applied the those hunks that were
> > failing to respective files. I could compile and build GtkLauncher. I
> was
> > unable to open any new window/popup when i click on the following href
> links
> >
> >
> > <html>
> > <body>
> > HTML version
> > <a href="a.html" target="_blank">Open window</a>
> > <br>
> >
> > Javascript version
> > <a href="javascript:window.open('a.html', '_blank')">Open window</a>
> >
> > </body>
> > </html>
> >
> > On the console i got the following error messages, This came only for
> the
> > first time:
> >
> > for HTML Version i got :
> >
> > UNIMPLEMENTED:
> > (../WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:770 virtual
> > WebCore::Frame* WebKit::FrameLoaderClient::dispatchCreatePage())
> > UNIMPLEMENTED:
> > (../WebCore/page/gtk/EventHandlerGtk.cpp:85 bool
> > WebCore::EventHandler::eventActivatedView(const
> > WebCore::PlatformMouseEvent&) const)
> >
> >
> > for JavaScript Version I got:
> >
> > UNIMPLEMENTED:
> > (../WebKit/gtk/webkit/webkitwebview.cpp:488 void
> > webkit_web_view_real_window_object_cleared(WebKitWebView*,
> WebKitWebFrame*,
> > OpaqueJSContext*, OpaqueJSValue*))
> > UNIMPLEMENTED:
> > (../WebCore/platform/gtk/PlatformScreenGtk.cpp:73 WebCore::FloatRect
> > WebCore::screenAvailableRect(WebCore::Widget*))
> > UNIMPLEMENTED:
> > (../WebKit/gtk/webkit/webkitwebview.cpp:481 WebKitWebView*
> > webkit_web_view_real_create_web_view(WebKitWebView*))
> >
> >
> > is there a way to get this patch working on the latest builds ?
> >
> > regards,
> > Srinivas Rao. M
> >
> >
> > >
> > > Dave
> > >
> > >
> > > Srinivas Rao M Hamse <msrinirao at gmail.com> wrote:
> > >
> > > > Hi David,
> > > >
> > > > Do you have any updates on this bug
> > > > (#16562<http://bugs.webkit.org/show_bug.cgi?id=16562>)?
> > > > When do we get the working version of this feature ?
> > > > regards,
> > > >
> > > > Srinivas Rao. M
> > > >
> > > > On Fri, Apr 11, 2008 at 9:27 PM, David Kilzer <ddkilzer at webkit.org>
> > > wrote:
> > > >
> > > > > Great! I just didn't recall seeing that listed before.
> > > > >
> > > > > Dave
> > > > >
> > > > >
> > > > > Srinivas Rao M Hamse <msrinirao at gmail.com> wrote:
> > > > >
> > > > > > Hi David,
> > > > > >
> > > > > > There is already a logged bug. Is this not sufficient ?
> > > > > >
> > > > > > http://bugs.webkit.org/show_bug.cgi?id=16562
> > > > > >
> > > > > >
> > > > > > regards,
> > > > > > Srinivas.
> > > > > >
> > > > > >
> > > > > > On Fri, Apr 11, 2008 at 7:53 PM, David Kilzer <
> ddkilzer at webkit.org>
> > > > > wrote:
> > > > > >
> > > > > > > Artem,
> > > > > > >
> > > > > > > Please file a bug on <https://bugs.webkit.org/> with a
> > > reproducible
> > > > > test
> > > > > > > case.
> > > > > > > Thanks!
> > > > > > >
> > > > > > > Dave
> > > > > > >
> > > > > > >
> > > > > > > Artem Ananiev <Artem.Ananiev at Sun.COM> wrote:
> > > > > > >
> > > > > > > > I have just tried GtkLauncher and it doesn't handle _blank
> > > target
> > > > > also.
> > > > > > > > Thus, it looks like a problem in a shared WebKit code, not
> > > specific
> > > > > to
> > > > > > > > out Java port...
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > >
> > > > > > > > Artem
> > > > > > > >
> > > > > > > > Artem Ananiev wrote:
> > > > > > > > > Hi,
> > > > > > > > >
> > > > > > > > > I have experienced the following problem with WebKit (Java
> > > port).
> > > > > The
> > > > > > > > > page code is simple:
> > > > > > > > >
> > > > > > > > > <a href="a.html" target="_blank">Open window</a>
> > > > > > > > > <a href="javascript:window.open('a.html',
> '_blank')">Open
> > > > > window</a>
> > > > > > > > >
> > > > > > > > > When I right-click on the first link and select 'Open in a
> new
> > > > > window'
> > > > > > > > > from context menu, a new window is created and shown -
> that's
> > > > > fine.
> > > > > > > > > However, left-click on the first link loads the page
> 'a.html'
> > > in
> > > > > the
> > > > > > > > > same window - this looks strange to me as the target is
> > > _blank.
> > > > > > > > >
> > > > > > > > > The second link behaves as expected: it opens a new window
> > > with
> > > > > > > > > left-click and does nothing with right click.
> > > > > > > > >
> > > > > > > > > I suppose target="_blank" is handled completely
> differently
> > > than
> > > > > > > opening
> > > > > > > > > a new window with a context menu. Is it related to popup
> > > blocking
> > > > > and
> > > > > > > > > different policies in FrameLoaderClient class? Another
> strange
> > > > > thing
> > > > > > > is
> > > > > > > > > that I couldn't find any references to
> > > > > ChromeClient::createWindow()
> > > > > > > > > method - it is responsible for creating a new window, at
> least
> > > > > > > triggered
> > > > > > > > > from context menu - other than from
> ContextMenuController...
> > > > > > > > >
> > > > > > > > > Thanks,
> > > > > > > > >
> > > > > > > > > Artem
> > > > > > > >
> > > > > > >
> > > > > >
> > > > > > --
> > > > > > Srinivas Rao M Hamse
> > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > Srinivas Rao M Hamse
> > > >
> > >
> > >
> >
> >
> > --
> > Srinivas Rao M Hamse <http://msrinirao.blogspot.com>
> >
>
>
--
Srinivas Rao M Hamse <http://msrinirao.blogspot.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.webkit.org/pipermail/webkit-dev/attachments/20080417/68a23522/attachment.html
More information about the webkit-dev
mailing list