[webkit-dev] Making use of a KJS_EXPORT macro

[Maciej Stachowiak]

Hey Geoff,

On Jun 1, 2007, at 9:51 AM, Geoffrey Garen wrote:

> Hi Luciano.
>
> I've found that the required exports from JavaScriptCore change all  
> the time based on new functionality in WebCore or architectural  
> changes in JavaScriptCore. I think that kind of documentation could  
> quickly get out of sync with reality.

As I understand it, it's not documentation, but an alternative way of  
controlling the actual exports. Instead of an export file you can  
declare symbol visibility at compile time. In theory this could  
somewhat improve codegen, since the compiler would know some  
functions are not exported at compile time, not just link time.

  - Maciej

>
> Geoff
>
> On Jun 1, 2007, at 1:19 AM, Luciano Montanaro wrote:
>
>> Hi all.
>> I'm trying to reconcile the KJS and JSC repositories, and one of the
>> differences I have found is the usage of the KJS_EXPORT macro, which
>> expands to
>> __attribute ((visibility("default"))) on GCC and
>> __declspec(dllexport) or __declspec(dllimport) on Microsoft  
>> compilers.
>>
>> I think it's a useful feature, and it offers a way to document  
>> which classes
>> are for internal use and which do not without cluttering the  
>> source code
>> too much.
>>
>> Would a patch for annotating classes and methods with this macro  
>> be welcome?
>>
>> Luciano
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo/webkit-dev
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-dev