[webkit-dev] type of JSChar
Darin Adler
darin at apple.com
Fri Jul 27 07:45:51 PDT 2007
On Jul 27, 2007, at 4:03 AM, Alexey Proskuryakov wrote:
> On 7/27/07 1:51 PM, "Simon Hausmann" <hausmann at kde.org> wrote:
>
>> Does anybody know/remember why JSChar is defined to wchar_t on
>> Windows and if
>> it is still needed?
>
> I think this was/is needed to match ICU's definition of UChar
> ("Define UChar to be wchar_t if that is 16 bits wide; always
> assumed to be unsigned. If wchar_t is not 16 bits wide, then define
> UChar to be uint16_t. This makes the definition of UChar platform-
> dependent but allows direct string type compatibility with
> platforms with 16-bit wchar_t types.")
That's correct. And for the same reasons we should follow the same
pattern for UChar, even when ICU is not involved.
I think that UnicodeQt4.h is the file that should be changed, not
JSStringRef.h.
-- Darin
More information about the webkit-dev
mailing list