[webkit-dev] Re: [webkit-changes] [29033] trunk

[Oliver Hunt]

Not necessarily -- I believe there are a number of generated headers  
that don't get generated if corresponding features are disabled, so  
the headers need to have #if ENABLED(...) checks around them... i  
think :D

--Oliver

On Dec 31, 2007, at 8:36 PM, Jan Alonzo wrote:

> (reposting to the list)
>
> On Jan 1, 2008 8:58 AM, Darin Adler <darin at apple.com> wrote:
>
> <snip>
>
>
> There are two approaches -- #if in the headers and #if in source files
> where they include the headers.
>
> Despite what Jan Alonzo claimed in that bug, we are consistently doing
> the #if in all the headers for these features; the #if in source files
> are mistakes.
>
> Yes, my mistake because i didn't poke in each of the header files  
> and based my comment on what I've seen in some of the source files  
> #if'ng header files. It's good to know that #ifng headers in source  
> files is a bug.
>
> Thanks for the clarification.
>
> Cheers _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.webkit.org/pipermail/webkit-dev/attachments/20071231/16512a57/attachment.html