[webkit-dev] Unused variable shouldDumpSubframesAsText in DumpRenderTree.m

Tue Aug 21 22:38:23 PDT 2007

On Tue, Aug 21, 2007 at 03:48:49PM -0700, Anyang Ren <anyang.ren at gmail.com> wrote:
> r24862 added an unused variable shouldDumpSubframesAsText
> to DumpRenderTree.m:

Speaking of unused variable, here is a list of warnings I got while
building the Qt and Gdk ports from r25144 with -Wall:

../../JavaScriptCore/wtf/TCSystemAlloc.cpp:65: warning: 'pagesize' defined but not used
../../JavaScriptCore/wtf/TCSystemAlloc.cpp:76: warning: 'use_sbrk' defined but not used
../../JavaScriptCore/wtf/TCSystemAlloc.cpp:77: warning: 'use_mmap' defined but not used
../../JavaScriptCore/kjs/collector.cpp:765: warning: unused variable 'currentThreadIsMainThread'
../../WebCore/html/CanvasStyle.cpp:94: warning: unused variable 'color'
../../WebCore/html/CanvasStyle.cpp:108: warning: unused variable 'color'
../../WebCore/html/CanvasStyle.cpp:170: warning: unused variable 'color'
../../WebCore/html/CanvasStyle.cpp:184: warning: unused variable 'color'
../../WebCore/html/HTMLCanvasElement.cpp:225: warning: unused variable 'w'
../../WebCore/html/HTMLCanvasElement.cpp:226: warning: unused variable 'h'
../../WebCore/page/gdk/EventHandlerGdk.cpp:81: warning: control reaches end of non-void function
../../WebCore/platform/gdk/FontDataGdk.cpp:97: warning: comparison between signed and unsigned integer expressions
../../WebCore/platform/gdk/PlatformScrollBarGdk.cpp:131: warning: passing 'gdouble' for argument 1 to 'bool WebCore::Scrollbar::setValue(int)'
../../WebCore/platform/gdk/ScrollViewGdk.cpp:510: warning: passing 'float' for argument 1 to 'void WebCore::ScrollView::scrollBy(int, int)'
../../WebCore/platform/gdk/ScrollViewGdk.cpp:510: warning: passing 'float' for argument 2 to 'void WebCore::ScrollView::scrollBy(int, int)'
../../WebCore/platform/network/curl/ResourceHandleManager.cpp:204: warning: unused variable 'err'
../../WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:824: warning: passing 'double' for argument 1 to 'WebCore::IntPoint::IntPoint(int, int)'
../../WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:824: warning: passing 'double' for argument 2 to 'WebCore::IntPoint::IntPoint(int, int)'
../../WebCore/platform/graphics/cairo/PathCairo.cpp:82: warning: unused variable 'cr'
../../WebCore/platform/image-decoders/gif/GIFImageDecoder.cpp:260: warning: unused variable 'src'
../../WebCore/platform/image-decoders/gif/GIFImageReader.cpp:760: warning: comparison between signed and unsigned integer expressions
../../WebCore/platform/image-decoders/png/PNGImageDecoder.cpp:230: warning: comparison between signed and unsigned integer expressions
../../WebCore/platform/image-decoders/png/PNGImageDecoder.cpp:230: warning: comparison between signed and unsigned integer expressions
../../WebCore/platform/image-decoders/png/PNGImageDecoder.cpp:372: warning: comparison between signed and unsigned integer expressions
../../WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:103: warning: 'src' may be used uninitialized in this function
../../WebKit/gtk/Api/webkitgtksettings.cpp:60: warning: control reaches end of non-void function
../../WebKit/gtk/Api/webkitgtksettings.cpp:48: warning: control reaches end of non-void function
../../WebKit/gtk/Api/webkitgtksettings.cpp:40: warning: control reaches end of non-void function
../../WebKit/gtk/Api/webkitgtksettings.cpp:36: warning: control reaches end of non-void function
../../WebKit/gtk/WebCoreSupport/DragClientGtk.cpp:66: warning: control reaches end of non-void function
../../WebKit/gtk/WebCoreSupport/DragClientGtk.cpp:56: warning: control reaches end of non-void function
../../WebKit/gtk/WebCoreSupport/DragClientGtk.cpp:51: warning: control reaches end of non-void function
../../WebCore/platform/graphics/svg/cairo/SVGPaintServerGradientCairo.cpp:74: warning: unused variable 'radial'
../../WebCore/platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp:64: warning: comparison between signed and unsigned integer expressions
../../JavaScriptCore/bindings/c/c_utility.cpp:191: warning: 'UTF16Length' is used uninitialized in this function
../../JavaScriptCore/bindings/c/c_utility.cpp:191: warning: 'methodName' is used uninitialized in this function
../../JavaScriptCore/bindings/c/c_utility.cpp:168: warning: 'UTF16Length' is used uninitialized in this function
../../JavaScriptCore/bindings/c/c_utility.cpp:168: warning: 'stringValue' is used uninitialized in this function
../../JavaScriptCore/kjs/collector.cpp:765: warning: unused variable 'currentThreadIsMainThread'
../../WebCore/dom/XMLTokenizer.cpp:1968: warning: unused variable 'decls'
../../WebCore/dom/XMLTokenizer.cpp:343: warning: 'WebCore::globalDescriptor' defined but not used
../../WebCore/dom/XMLTokenizer.cpp:345: warning: 'int WebCore::matchFunc(const char*)' defined but not used
../../WebCore/dom/XMLTokenizer.cpp:350: warning: 'WebCore::globalDocLoader' defined but not used
../../WebCore/platform/MIMETypeRegistry.cpp:86: warning: comparison between signed and unsigned integer expressions
../../WebCore/platform/graphics/qt/GraphicsContextQt.cpp:549: warning: comparison between signed and unsigned integer expressions
../../WebCore/platform/graphics/qt/ImageDecoderQt.cpp:264: warning: comparison between signed and unsigned integer expressions
../../WebCore/platform/graphics/qt/ImageDecoderQt.cpp:280: warning: comparison between signed and unsigned integer expressions
../../WebCore/platform/qt/ContextMenuQt.cpp:80: warning: unused variable 'id'
../../WebCore/platform/qt/ContextMenuQt.cpp:81: warning: 'action' may be used uninitialized in this function
../../WebCore/platform/qt/FontQt.cpp:291: warning: comparison between signed and unsigned integer expressions
../../WebCore/platform/qt/FontQt.cpp:299: warning: comparison between signed and unsigned integer expressions
../../WebCore/platform/qt/FontQt.cpp:342: warning: comparison between signed and unsigned integer expressions
../../WebCore/platform/qt/FontQt.cpp:366: warning: comparison between signed and unsigned integer expressions
../../WebCore/platform/qt/FontQt.cpp:397: warning: comparison between signed and unsigned integer expressions
../../WebCore/platform/qt/PlatformScrollBarQt.cpp:56: warning: unused variable 's'
../../WebCore/platform/qt/PlatformScrollBarQt.cpp:140: warning: unused variable 's'
../../WebCore/platform/qt/PlatformScrollBarQt.cpp:180: warning: converting to 'int' from 'float'
../../WebCore/platform/qt/PlatformScrollBarQt.cpp:233: warning: passing 'float' for argument 1 to 'bool WebCore::Scrollbar::setValue(int)'
../../WebCore/platform/qt/PlugInInfoStoreQt.cpp:34: warning: comparison between signed and unsigned integer expressions
../../WebCore/platform/qt/RenderThemeQt.cpp:314: warning: unused variable 'appearance'
../../WebCore/platform/qt/RenderThemeQt.cpp:445: warning: enumeration value 'NoAppearance' not handled in switch
../../WebCore/platform/qt/RenderThemeQt.cpp:445: warning: enumeration value 'CheckboxAppearance' not handled in switch
../../WebCore/platform/qt/RenderThemeQt.cpp:445: warning: enumeration value 'RadioAppearance' not handled in switch
../../WebCore/platform/qt/RenderThemeQt.cpp:445: warning: enumeration value 'ListboxAppearance' not handled in switch
../../WebCore/platform/qt/RenderThemeQt.cpp:445: warning: enumeration value 'MenulistAppearance' not handled in switch
../../WebCore/platform/qt/RenderThemeQt.cpp:445: warning: enumeration value 'MenulistTextAppearance' not handled in switch
../../WebCore/platform/qt/RenderThemeQt.cpp:445: warning: enumeration value 'MenulistTextFieldAppearance' not handled in switch
../../WebCore/platform/qt/RenderThemeQt.cpp:445: warning: enumeration value 'ScrollbarButtonUpAppearance' not handled in switch
../../WebCore/platform/qt/RenderThemeQt.cpp:445: warning: enumeration value 'ScrollbarButtonDownAppearance' not handled in switch
../../WebCore/platform/qt/RenderThemeQt.cpp:445: warning: enumeration value 'ScrollbarGripperHorizontalAppearance' not handled in switch
../../WebCore/platform/qt/RenderThemeQt.cpp:445: warning: enumeration value 'ScrollbarGripperVerticalAppearance' not handled in switch
../../WebCore/platform/qt/RenderThemeQt.cpp:445: warning: enumeration value 'SliderHorizontalAppearance' not handled in switch
../../WebCore/platform/qt/RenderThemeQt.cpp:445: warning: enumeration value 'SliderVerticalAppearance' not handled in switch
../../WebCore/platform/qt/RenderThemeQt.cpp:445: warning: enumeration value 'SliderThumbHorizontalAppearance' not handled in switch
../../WebCore/platform/qt/RenderThemeQt.cpp:445: warning: enumeration value 'SliderThumbVerticalAppearance' not handled in switch
../../WebCore/platform/qt/RenderThemeQt.cpp:445: warning: enumeration value 'CaretAppearance' not handled in switch
../../WebCore/platform/qt/RenderThemeQt.cpp:445: warning: enumeration value 'SearchFieldAppearance' not handled in switch
../../WebCore/platform/qt/RenderThemeQt.cpp:445: warning: enumeration value 'SearchFieldDecorationAppearance' not handled in switch
../../WebCore/platform/qt/RenderThemeQt.cpp:445: warning: enumeration value 'SearchFieldResultsDecorationAppearance' not handled in switch
../../WebCore/platform/qt/RenderThemeQt.cpp:445: warning: enumeration value 'TextFieldAppearance' not handled in switch
../../WebCore/platform/qt/RenderThemeQt.cpp:445: warning: enumeration value 'TextAreaAppearance' not handled in switch
../../WebCore/platform/qt/ScrollViewQt.cpp:378: warning: unused variable 'oldView'
../../WebCore/platform/qt/ScrollViewQt.cpp:618: warning: unused variable 'p'
../../WebCore/platform/qt/ScrollViewQt.cpp:697: warning: passing 'float' for argument 1 to 'void WebCore::ScrollView::scrollBy(int, int)'
../../WebCore/platform/qt/ScrollViewQt.cpp:697: warning: passing 'float' for argument 2 to 'void WebCore::ScrollView::scrollBy(int, int)'
../../WebCore/platform/qt/TextBreakIteratorQt.cpp:29: warning: 'class WebCore::TextBreakIterator' has virtual functions but non-virtual destructor
../../WebCore/platform/qt/TextBreakIteratorQt.cpp:48: warning: 'class WebCore::WordBreakIteratorQt' has virtual functions but non-virtual destructor
../../WebCore/platform/qt/TextBreakIteratorQt.cpp:56: warning: 'class WebCore::CharBreakIteratorQt' has virtual functions but non-virtual destructor
../../WebKitQt/WebCoreSupport/FrameLoaderClientQt.cpp:836: warning: unused variable 'loadType'
../../WebKitQt/WebCoreSupport/FrameLoaderClientQt.cpp:896: warning: comparison between signed and unsigned integer expressions
../../WebKitQt/WebCoreSupport/FrameLoaderClientQt.cpp:898: warning: comparison between signed and unsigned integer expressions
../../WebKitQt/WebCoreSupport/FrameLoaderClientQt.cpp:916: warning: comparison between signed and unsigned integer expressions
../../WebKitQt/Api/qwebframe.cpp:218: warning: comparison between 'enum WebCore::ScrollbarMode' and 'enum Qt::ScrollBarPolicy'
../../WebKitQt/Api/qwebframe.cpp:219: warning: comparison between 'enum WebCore::ScrollbarMode' and 'enum Qt::ScrollBarPolicy'
../../WebKitQt/Api/qwebframe.cpp:220: warning: comparison between 'enum WebCore::ScrollbarMode' and 'enum Qt::ScrollBarPolicy'
../../WebKitQt/Api/qwebnetworkinterface.cpp:881: warning: unused variable 'proxyId'
../../WebKitQt/Api/qwebpage.cpp:544: warning: unused variable 'action'
../../WebKitQt/Api/qwebpagehistory.cpp:115: warning: comparison between signed and unsigned integer expressions
../../WebKitQt/Api/qwebpagehistory.cpp:128: warning: comparison between signed and unsigned integer expressions
../../WebKitQt/Api/qwebpagehistory.cpp:141: warning: comparison between signed and unsigned integer expressions
../../WebCore/platform/graphics/svg/qt/SVGPaintServerRadialGradientQt.cpp:45: warning: unused variable 'renderStyle'
../../../JavaScriptCore/bindings/c/c_utility.cpp:53: warning: unused parameter 'UTF8Chars'
../../../JavaScriptCore/bindings/c/c_utility.cpp:53: warning: unused parameter 'UTF8Length'
../../../JavaScriptCore/bindings/c/c_utility.cpp:53: warning: unused parameter 'UTF16Chars'
../../../JavaScriptCore/bindings/c/c_utility.cpp:53: warning: unused parameter 'UTF16Length'
../../../JavaScriptCore/bindings/qt/qt_instance.cpp:137: warning: unused parameter 'exec'
../../../JavaScriptCore/bindings/qt/qt_instance.cpp:137: warning: unused parameter 'args'
../../../../WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:61: warning: unused parameter 'frame'

I don't know if I should file a bug or several bugs.

Mike