[webkit-dev] Newline translation issue with textareas

Kevin Ballard kevin at sb.org
Mon Jun 20 14:03:50 PDT 2005

Alright, I'll do the translation in  
HTMLTextAreaElementImpl::setValue. And yes, it is a QString, although  
the QString is taken from a const DOMString, and those replace calls  
look like they replace-in-place. I'm not familiar with QString (or  
DOMString) yet, so is there any issue with calling these 2 lines on  
the QString returned by value.string() (where value is a const  
DOMString &)? Is that returning a value in the DOMString, or does the  
DOMString::string call copy its contents into a new QString?

I could probably figure this out by looking at the code, but I just  
thought it might be faster to ask.

On Jun 20, 2005, at 4:55 PM, Darin Adler wrote:

> Nah, I think it's OK to have the translation in two different  
> places for now. If this was a QString, we'd be talking two lines of  
> code here:
>     xxx.replace("\r\n", '\n');
>     xxx.replace('\r', '\n');
> Lets not bend over too far backwards for this.

Kevin Ballard
kevin at sb.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2378 bytes
Desc: not available
Url : http://lists.macosforge.org/pipermail/webkit-dev/attachments/20050620/e7522bf6/smime.bin

More information about the webkit-dev mailing list