<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[288288] releases/WebKitGTK/webkit-2.34/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/288288">288288</a></dd>
<dt>Author</dt> <dd>aperez@igalia.com</dd>
<dt>Date</dt> <dd>2022-01-20 07:46:28 -0800 (Thu, 20 Jan 2022)</dd>
</dl>

<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/287428">r287428</a> - Simplify test for startOfLastParagraph in InsertListCommand::doApply
https://bugs.webkit.org/show_bug.cgi?id=234600

Patch by Frederic Wang <fwang@igalia.com> on 2021-12-24
Reviewed by Darin Adler.

Current test is !startOfLastParagraph.deepEquivalent().anchorNode()->isConnected(). It could
be replaced with the less verbose startOfLastParagraph.isOrphan() which is equivalent to
startOfLastParagraph.deepEquivalent().isOrphan() and so to the condition
startOfLastParagraph.deepEquivalent().anchorNode() &&
!startOfLastParagraph.deepEquivalent().anchorNode()->isConnected(). A difference can only
happen for a page where anchorNode() is a null pointer. In such a test case exists, then it
is already crashing with a null ptr deref anyway.

No new tests, behavior essentially unchanged.

* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply): Use startOfLastParagraph.isOrphan().</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit234SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit234SourceWebCoreeditingInsertListCommandcpp">releases/WebKitGTK/webkit-2.34/Source/WebCore/editing/InsertListCommand.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit234SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog (288287 => 288288)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog  2022-01-20 15:41:36 UTC (rev 288287)
+++ releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog     2022-01-20 15:46:28 UTC (rev 288288)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2021-12-24  Frederic Wang  <fwang@igalia.com>
+
+        Simplify test for startOfLastParagraph in InsertListCommand::doApply
+        https://bugs.webkit.org/show_bug.cgi?id=234600
+
+        Reviewed by Darin Adler.
+
+        Current test is !startOfLastParagraph.deepEquivalent().anchorNode()->isConnected(). It could
+        be replaced with the less verbose startOfLastParagraph.isOrphan() which is equivalent to
+        startOfLastParagraph.deepEquivalent().isOrphan() and so to the condition
+        startOfLastParagraph.deepEquivalent().anchorNode() &&
+        !startOfLastParagraph.deepEquivalent().anchorNode()->isConnected(). A difference can only
+        happen for a page where anchorNode() is a null pointer. In such a test case exists, then it
+        is already crashing with a null ptr deref anyway.
+
+        No new tests, behavior essentially unchanged.
+
+        * editing/InsertListCommand.cpp:
+        (WebCore::InsertListCommand::doApply): Use startOfLastParagraph.isOrphan().
+
</ins><span class="cx"> 2021-12-23  Philippe Normand  <pnormand@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         [GStreamer] MediaPlayerPrivateGStreamer mishandles failure to create WebKitTextCombiner
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit234SourceWebCoreeditingInsertListCommandcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/editing/InsertListCommand.cpp (288287 => 288288)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.34/Source/WebCore/editing/InsertListCommand.cpp      2022-01-20 15:41:36 UTC (rev 288287)
+++ releases/WebKitGTK/webkit-2.34/Source/WebCore/editing/InsertListCommand.cpp 2022-01-20 15:46:28 UTC (rev 288288)
</span><span class="lines">@@ -155,7 +155,7 @@
</span><span class="cx">                     // infinite loop and because there is no more work to be done.
</span><span class="cx">                     // FIXME(<rdar://problem/5983974>): The endingSelection() may be incorrect here. Compute
</span><span class="cx">                     // the new location of endOfSelection and use it as the end of the new selection.
</span><del>-                    if (!startOfLastParagraph.deepEquivalent().anchorNode()->isConnected())
</del><ins>+                    if (startOfLastParagraph.isOrphan())
</ins><span class="cx">                         return;
</span><span class="cx">                     setEndingSelection(startOfCurrentParagraph);
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>