<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[288265] trunk/Source/bmalloc</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/288265">288265</a></dd>
<dt>Author</dt> <dd>ysuzuki@apple.com</dd>
<dt>Date</dt> <dd>2022-01-19 18:40:37 -0800 (Wed, 19 Jan 2022)</dd>
</dl>

<h3>Log Message</h3>
<pre>[libpas] Disable PAS_ASSERT on Darwin ARM64 (not in ARM64E)
https://bugs.webkit.org/show_bug.cgi?id=235349

Reviewed by Saam Barati.

We have several weak devices which only have ARM64 (not ARM64E).
And in such a weak device, PAS_ASSERT affects on performance.
By disabling PAS_ASSERT, we got 0.5% improvement in PLT in iPhone 6S.

* libpas/src/libpas/pas_config.h:
* libpas/src/libpas/pas_config_prefix.h:
* libpas/src/libpas/pas_internal_config.h:
* libpas/src/libpas/pas_platform.h:
* libpas/src/libpas/pas_utils.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourcebmallocChangeLog">trunk/Source/bmalloc/ChangeLog</a></li>
<li><a href="#trunkSourcebmalloclibpassrclibpaspas_configh">trunk/Source/bmalloc/libpas/src/libpas/pas_config.h</a></li>
<li><a href="#trunkSourcebmalloclibpassrclibpaspas_config_prefixh">trunk/Source/bmalloc/libpas/src/libpas/pas_config_prefix.h</a></li>
<li><a href="#trunkSourcebmalloclibpassrclibpaspas_internal_configh">trunk/Source/bmalloc/libpas/src/libpas/pas_internal_config.h</a></li>
<li><a href="#trunkSourcebmalloclibpassrclibpaspas_platformh">trunk/Source/bmalloc/libpas/src/libpas/pas_platform.h</a></li>
<li><a href="#trunkSourcebmalloclibpassrclibpaspas_utilsh">trunk/Source/bmalloc/libpas/src/libpas/pas_utils.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourcebmallocChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/bmalloc/ChangeLog (288264 => 288265)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/bmalloc/ChangeLog   2022-01-20 02:05:52 UTC (rev 288264)
+++ trunk/Source/bmalloc/ChangeLog      2022-01-20 02:40:37 UTC (rev 288265)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2022-01-19  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [libpas] Disable PAS_ASSERT on Darwin ARM64 (not in ARM64E)
+        https://bugs.webkit.org/show_bug.cgi?id=235349
+
+        Reviewed by Saam Barati.
+
+        We have several weak devices which only have ARM64 (not ARM64E).
+        And in such a weak device, PAS_ASSERT affects on performance.
+        By disabling PAS_ASSERT, we got 0.5% improvement in PLT in iPhone 6S.
+
+        * libpas/src/libpas/pas_config.h:
+        * libpas/src/libpas/pas_config_prefix.h:
+        * libpas/src/libpas/pas_internal_config.h:
+        * libpas/src/libpas/pas_platform.h:
+        * libpas/src/libpas/pas_utils.h:
+
</ins><span class="cx"> 2022-01-18  Alex Christensen  <achristensen@webkit.org>
</span><span class="cx"> 
</span><span class="cx">         Use c++2a instead of gnu++2a for Cocoa builds
</span></span></pre></div>
<a id="trunkSourcebmalloclibpassrclibpaspas_configh"></a>
<div class="modfile"><h4>Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_config.h (288264 => 288265)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/bmalloc/libpas/src/libpas/pas_config.h      2022-01-20 02:05:52 UTC (rev 288264)
+++ trunk/Source/bmalloc/libpas/src/libpas/pas_config.h 2022-01-20 02:40:37 UTC (rev 288265)
</span><span class="lines">@@ -38,6 +38,11 @@
</span><span class="cx"> #endif
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><ins>+#if PAS_OS(DARWIN) && __PAS_ARM64 && !__PAS_ARM64E && defined(NDEBUG)
+#define PAS_ENABLE_ASSERT 0
+#else
+#define PAS_ENABLE_ASSERT 1
+#endif
</ins><span class="cx"> #define PAS_ENABLE_TESTING __PAS_ENABLE_TESTING
</span><span class="cx"> 
</span><span class="cx"> #define PAS_ARM64 __PAS_ARM64
</span></span></pre></div>
<a id="trunkSourcebmalloclibpassrclibpaspas_config_prefixh"></a>
<div class="modfile"><h4>Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_config_prefix.h (288264 => 288265)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/bmalloc/libpas/src/libpas/pas_config_prefix.h       2022-01-20 02:05:52 UTC (rev 288264)
+++ trunk/Source/bmalloc/libpas/src/libpas/pas_config_prefix.h  2022-01-20 02:40:37 UTC (rev 288265)
</span><span class="lines">@@ -23,6 +23,11 @@
</span><span class="cx">  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
</span><span class="cx">  */
</span><span class="cx"> 
</span><ins>+#ifndef PAS_CONFIG_PREFIX_H
+#define PAS_CONFIG_PREFIX_H
+
+#include "pas_platform.h"
+
</ins><span class="cx"> #if defined(ENABLE_PAS_TESTING)
</span><span class="cx"> #define __PAS_ENABLE_TESTING 1
</span><span class="cx"> #else
</span><span class="lines">@@ -54,3 +59,5 @@
</span><span class="cx"> #else
</span><span class="cx"> #define __PAS_RISCV 0
</span><span class="cx"> #endif
</span><ins>+
+#endif /* PAS_CONFIG_PREFIX_H */
</ins></span></pre></div>
<a id="trunkSourcebmalloclibpassrclibpaspas_internal_configh"></a>
<div class="modfile"><h4>Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_internal_config.h (288264 => 288265)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/bmalloc/libpas/src/libpas/pas_internal_config.h     2022-01-20 02:05:52 UTC (rev 288264)
+++ trunk/Source/bmalloc/libpas/src/libpas/pas_internal_config.h        2022-01-20 02:40:37 UTC (rev 288265)
</span><span class="lines">@@ -27,7 +27,6 @@
</span><span class="cx"> #define PAS_INTERNAL_CONFIG_H
</span><span class="cx"> 
</span><span class="cx"> #include "pas_config.h"
</span><del>-#include "pas_platform.h"
</del><span class="cx"> 
</span><span class="cx"> #define PAS_SUBPAGE_SIZE                 4096
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourcebmalloclibpassrclibpaspas_platformh"></a>
<div class="modfile"><h4>Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_platform.h (288264 => 288265)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/bmalloc/libpas/src/libpas/pas_platform.h    2022-01-20 02:05:52 UTC (rev 288264)
+++ trunk/Source/bmalloc/libpas/src/libpas/pas_platform.h       2022-01-20 02:40:37 UTC (rev 288265)
</span><span class="lines">@@ -32,6 +32,7 @@
</span><span class="cx"> #include <TargetConditionals.h>
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><ins>+/* PAS_COMPILER() - the target compiler */
</ins><span class="cx"> #define PAS_COMPILER(FEATURE) (defined PAS_COMPILER_##FEATURE  && PAS_COMPILER_##FEATURE)
</span><span class="cx"> 
</span><span class="cx"> #if defined(__clang__)
</span></span></pre></div>
<a id="trunkSourcebmalloclibpassrclibpaspas_utilsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_utils.h (288264 => 288265)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/bmalloc/libpas/src/libpas/pas_utils.h       2022-01-20 02:05:52 UTC (rev 288264)
+++ trunk/Source/bmalloc/libpas/src/libpas/pas_utils.h  2022-01-20 02:40:37 UTC (rev 288265)
</span><span class="lines">@@ -200,6 +200,8 @@
</span><span class="cx"> 
</span><span class="cx"> #define PAS_ASSERT(exp) \
</span><span class="cx">     do { \
</span><ins>+        if (!PAS_ENABLE_ASSERT) \
+            break; \
</ins><span class="cx">         if (PAS_LIKELY(exp)) \
</span><span class="cx">             break; \
</span><span class="cx">         pas_assertion_failed_noreturn_silencer(__FILE__, __LINE__, __PRETTY_FUNCTION__, #exp); \
</span></span></pre>
</div>
</div>

</body>
</html>