<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[287425] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/287425">287425</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2021-12-24 02:50:26 -0800 (Fri, 24 Dec 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>[GTK][a11y] Expose live region attributes with ATSPI
https://bugs.webkit.org/show_bug.cgi?id=234637

Reviewed by Adrian Perez de Castro.

Source/WebCore:

* accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::attributes const):

Tools:

* WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::boolAttributeValue):
(WTR::AccessibilityUIElement::isAttributeSupported):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityatspiAccessibilityObjectAtspicpp">trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundleatspiAccessibilityUIElementAtspicpp">trunk/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (287424 => 287425)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2021-12-24 10:48:46 UTC (rev 287424)
+++ trunk/Source/WebCore/ChangeLog      2021-12-24 10:50:26 UTC (rev 287425)
</span><span class="lines">@@ -1,5 +1,15 @@
</span><span class="cx"> 2021-12-24  Carlos Garcia Campos  <cgarcia@igalia.com>
</span><span class="cx"> 
</span><ins>+        [GTK][a11y] Expose live region attributes with ATSPI
+        https://bugs.webkit.org/show_bug.cgi?id=234637
+
+        Reviewed by Adrian Perez de Castro.
+
+        * accessibility/atspi/AccessibilityObjectAtspi.cpp:
+        (WebCore::AccessibilityObjectAtspi::attributes const):
+
+2021-12-24  Carlos Garcia Campos  <cgarcia@igalia.com>
+
</ins><span class="cx">         [GTK][a11y] Expose the right roles for math elements with ATSPI
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=234634
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityatspiAccessibilityObjectAtspicpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp (287424 => 287425)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp    2021-12-24 10:48:46 UTC (rev 287424)
+++ trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp       2021-12-24 10:50:26 UTC (rev 287425)
</span><span class="lines">@@ -1030,6 +1030,27 @@
</span><span class="cx">     else if (m_coreObject->isMathMultiscriptObject(AccessibilityMathMultiscriptObjectType::PostSuperscript) || m_coreObject->isMathMultiscriptObject(AccessibilityMathMultiscriptObjectType::PostSubscript))
</span><span class="cx">         map.add("multiscript-type", "post");
</span><span class="cx"> 
</span><ins>+    if (auto* liveContainer = m_coreObject->liveRegionAncestor(false)) {
+        auto liveStatus = liveContainer->liveRegionStatus();
+        map.add("container-live", liveStatus);
+        auto relevant = liveContainer->liveRegionRelevant();
+        map.add("container-relevant", relevant);
+        bool isAtomic = liveContainer->liveRegionAtomic();
+        if (isAtomic)
+            map.add("container-atomic", "true");
+        const String& liveRole = roleString.isEmpty() ? computedRoleString : roleString;
+        if (!liveRole.isEmpty())
+            map.add("container-live-role", liveRole);
+
+        if (liveContainer == m_coreObject) {
+            map.add("live", liveStatus);
+            map.add("relevant", relevant);
+            if (isAtomic)
+                map.add("atomic", "true");
+        } else if (!isAtomic && m_coreObject->liveRegionAtomic())
+            map.add("atomic", "true");
+    }
+
</ins><span class="cx">     return map;
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (287424 => 287425)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog    2021-12-24 10:48:46 UTC (rev 287424)
+++ trunk/Tools/ChangeLog       2021-12-24 10:50:26 UTC (rev 287425)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2021-12-24  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK][a11y] Expose live region attributes with ATSPI
+        https://bugs.webkit.org/show_bug.cgi?id=234637
+
+        Reviewed by Adrian Perez de Castro.
+
+        * WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:
+        (WTR::AccessibilityUIElement::stringAttributeValue):
+        (WTR::AccessibilityUIElement::boolAttributeValue):
+        (WTR::AccessibilityUIElement::isAttributeSupported):
+
</ins><span class="cx"> 2021-12-23  Wenson Hsieh  <wenson_hsieh@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Modal container control classifier fails on some neutral controls that contain multiplication symbols
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundleatspiAccessibilityUIElementAtspicpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp (287424 => 287425)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp        2021-12-24 10:48:46 UTC (rev 287424)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp   2021-12-24 10:50:26 UTC (rev 287425)
</span><span class="lines">@@ -371,6 +371,10 @@
</span><span class="cx">             value = checkElementState(m_element.get(), WebCore::Atspi::State::InvalidEntry) ? "true" : "false";
</span><span class="cx">         return OpaqueJSString::tryCreate(value).leakRef();
</span><span class="cx">     }
</span><ins>+    if (attributeName == "AXARIALive")
+        return OpaqueJSString::tryCreate(attributes.get("live")).leakRef();
+    if (attributeName == "AXARIARelevant")
+        return OpaqueJSString::tryCreate(attributes.get("relevant")).leakRef();
</ins><span class="cx"> 
</span><span class="cx">     return JSStringCreateWithCharacters(nullptr, 0);
</span><span class="cx"> }
</span><span class="lines">@@ -469,6 +473,8 @@
</span><span class="cx">         return m_element->interfaces().contains(WebCore::AccessibilityObjectAtspi::Interface::Table);
</span><span class="cx">     if (attributeName == "AXInterfaceTableCell")
</span><span class="cx">         return m_element->interfaces().contains(WebCore::AccessibilityObjectAtspi::Interface::TableCell);
</span><ins>+    if (attributeName == "AXARIAAtomic")
+        return m_element->attributes().get("atomic") == "true";
</ins><span class="cx"> 
</span><span class="cx">     return false;
</span><span class="cx"> }
</span><span class="lines">@@ -539,6 +545,16 @@
</span><span class="cx">         return attributes.contains("setsize");
</span><span class="cx">     if (attributeName == "AXARIAPosInSet")
</span><span class="cx">         return attributes.contains("posinset");
</span><ins>+    if (attributeName == "AXARIALive") {
+        auto value = attributes.get("live");
+        return !value.isEmpty() && value != "off";
+    }
+    if (attributeName == "AXARIARelevant")
+        return attributes.contains("relevant");
+    if (attributeName == "AXARIAAtomic")
+        return attributes.contains("atomic");
+    if (attributeName == "AXElementBusy")
+        return true;
</ins><span class="cx"> 
</span><span class="cx">     return false;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>

</body>
</html>