<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[287204] trunk/Source/ThirdParty/ANGLE</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/287204">287204</a></dd>
<dt>Author</dt> <dd>Hironori.Fujii@sony.com</dd>
<dt>Date</dt> <dd>2021-12-17 13:39:12 -0800 (Fri, 17 Dec 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>[ANGLE] "WARN: driver_utils.cpp:169 (rx::GetVendorString):! Unimplemented: rx::GetVendorString" on WinCairo debug testing bot
https://bugs.webkit.org/show_bug.cgi?id=234371

Reviewed by Kenneth Russell.

After <a href="http://trac.webkit.org/projects/webkit/changeset/286603">r286603</a> updated ANGLE, WinCairo debug testing bot was
observing annoying warning message for all WebGL tessts.
> WARN: driver_utils.cpp:169 (rx::GetVendorString):  ! Unimplemented: rx::GetVendorString(..\..\Source\ThirdParty\ANGLE\src\libANGLE\renderer\driver_utils.cpp:169)

The vendor ID was 0x1414 (Microsoft).
<https://pcisig.com/membership/member-companies>

* src/libANGLE/renderer/driver_utils.cpp:
(rx::GetVendorString): Added more vendor strings for vendor IDs.
* src/libANGLE/renderer/driver_utils.h: Added VENDOR_ID_MICROSOFT.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceThirdPartyANGLEChangeLog">trunk/Source/ThirdParty/ANGLE/ChangeLog</a></li>
<li><a href="#trunkSourceThirdPartyANGLEsrclibANGLErendererdriver_utilscpp">trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/driver_utils.cpp</a></li>
<li><a href="#trunkSourceThirdPartyANGLEsrclibANGLErendererdriver_utilsh">trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/driver_utils.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceThirdPartyANGLEChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (287203 => 287204)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/ThirdParty/ANGLE/ChangeLog  2021-12-17 21:05:42 UTC (rev 287203)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog     2021-12-17 21:39:12 UTC (rev 287204)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2021-12-17  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [ANGLE] "WARN: driver_utils.cpp:169 (rx::GetVendorString):! Unimplemented: rx::GetVendorString" on WinCairo debug testing bot
+        https://bugs.webkit.org/show_bug.cgi?id=234371
+
+        Reviewed by Kenneth Russell.
+
+        After r286603 updated ANGLE, WinCairo debug testing bot was
+        observing annoying warning message for all WebGL tessts.
+        > WARN: driver_utils.cpp:169 (rx::GetVendorString):         ! Unimplemented: rx::GetVendorString(..\..\Source\ThirdParty\ANGLE\src\libANGLE\renderer\driver_utils.cpp:169)
+
+        The vendor ID was 0x1414 (Microsoft).
+        <https://pcisig.com/membership/member-companies>
+
+        * src/libANGLE/renderer/driver_utils.cpp:
+        (rx::GetVendorString): Added more vendor strings for vendor IDs.
+        * src/libANGLE/renderer/driver_utils.h: Added VENDOR_ID_MICROSOFT.
+
</ins><span class="cx"> 2021-12-17  Kimmo Kinnunen  <kkinnunen@apple.com>
</span><span class="cx"> 
</span><span class="cx">         REGRESSION (r287068): [macOS arm64] TestWebKitAPI.GraphicsContextGLCocoaTest.UnrecycledDisplayBuffersNoLeaks is failing
</span></span></pre></div>
<a id="trunkSourceThirdPartyANGLEsrclibANGLErendererdriver_utilscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/driver_utils.cpp (287203 => 287204)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/driver_utils.cpp     2021-12-17 21:05:42 UTC (rev 287203)
+++ trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/driver_utils.cpp        2021-12-17 21:39:12 UTC (rev 287204)
</span><span class="lines">@@ -146,6 +146,8 @@
</span><span class="cx">             return "ARM";
</span><span class="cx">         case VENDOR_ID_APPLE:
</span><span class="cx">             return "Apple";
</span><ins>+        case VENDOR_ID_MICROSOFT:
+            return "Microsoft";
</ins><span class="cx">         case VENDOR_ID_BROADCOM:
</span><span class="cx">             return "Broadcom";
</span><span class="cx">         case VENDOR_ID_GOOGLE:
</span><span class="lines">@@ -160,6 +162,12 @@
</span><span class="cx">             return "Imagination Technologies";
</span><span class="cx">         case VENDOR_ID_QUALCOMM:
</span><span class="cx">             return "Qualcomm";
</span><ins>+        case VENDOR_ID_SAMSUNG:
+            return "Samsung";
+        case VENDOR_ID_VMWARE:
+            return "VMware";
+        case VENDOR_ID_VIVANTE:
+            return "Vivante";
</ins><span class="cx">         case 0xba5eba11:  // Mock vendor ID used for tests.
</span><span class="cx">             return "Test";
</span><span class="cx">         case 0:
</span></span></pre></div>
<a id="trunkSourceThirdPartyANGLEsrclibANGLErendererdriver_utilsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/driver_utils.h (287203 => 287204)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/driver_utils.h       2021-12-17 21:05:42 UTC (rev 287203)
+++ trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/driver_utils.h  2021-12-17 21:39:12 UTC (rev 287204)
</span><span class="lines">@@ -21,6 +21,7 @@
</span><span class="cx">     VENDOR_ID_AMD     = 0x1002,
</span><span class="cx">     VENDOR_ID_APPLE   = 0x106B,
</span><span class="cx">     VENDOR_ID_ARM     = 0x13B5,
</span><ins>+    VENDOR_ID_MICROSOFT = 0x1414,
</ins><span class="cx">     // Broadcom devices won't use PCI, but this is their Vulkan vendor id.
</span><span class="cx">     VENDOR_ID_BROADCOM = 0x14E4,
</span><span class="cx">     VENDOR_ID_GOOGLE   = 0x1AE0,
</span></span></pre>
</div>
</div>

</body>
</html>