<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[286878] trunk/Source</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/286878">286878</a></dd>
<dt>Author</dt> <dd>beidson@apple.com</dd>
<dt>Date</dt> <dd>2021-12-10 14:19:03 -0800 (Fri, 10 Dec 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Teach webpushd to launch an app in response to an injected message.
https://bugs.webkit.org/show_bug.cgi?id=234122

Reviewed by Alex Christensen.

Source/WebCore/PAL:

* pal/spi/cocoa/LaunchServicesSPI.h:

Source/WebKit:

To by covered by future API test.

When a message comes in, webpushd knows which code signing identifier it was targetted for.
It launches that app in a special mode so the app can then "take it from there"

* webpushd/WebPushDaemon.h:
* webpushd/WebPushDaemon.mm:
(WebPushD::Daemon::injectPushMessageForTesting):
(WebPushD::Daemon::notifyClientPushMessageIsAvailable):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCorePALChangeLog">trunk/Source/WebCore/PAL/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorePALpalspicocoaLaunchServicesSPIh">trunk/Source/WebCore/PAL/pal/spi/cocoa/LaunchServicesSPI.h</a></li>
<li><a href="#trunkSourceWebKitChangeLog">trunk/Source/WebKit/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitwebpushdWebPushDaemonh">trunk/Source/WebKit/webpushd/WebPushDaemon.h</a></li>
<li><a href="#trunkSourceWebKitwebpushdWebPushDaemonmm">trunk/Source/WebKit/webpushd/WebPushDaemon.mm</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCorePALChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/PAL/ChangeLog (286877 => 286878)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/PAL/ChangeLog       2021-12-10 22:17:27 UTC (rev 286877)
+++ trunk/Source/WebCore/PAL/ChangeLog  2021-12-10 22:19:03 UTC (rev 286878)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2021-12-10  Brady Eidson  <beidson@apple.com>
+
+        Teach webpushd to launch an app in response to an injected message.
+        https://bugs.webkit.org/show_bug.cgi?id=234122
+
+        Reviewed by Alex Christensen.
+
+        * pal/spi/cocoa/LaunchServicesSPI.h:
+
</ins><span class="cx"> 2021-12-10  Antoine Quint  <graouts@webkit.org>
</span><span class="cx"> 
</span><span class="cx">         Expose the maximum device frame rate to the Web Animations model
</span></span></pre></div>
<a id="trunkSourceWebCorePALpalspicocoaLaunchServicesSPIh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/PAL/pal/spi/cocoa/LaunchServicesSPI.h (286877 => 286878)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/PAL/pal/spi/cocoa/LaunchServicesSPI.h       2021-12-10 22:17:27 UTC (rev 286877)
+++ trunk/Source/WebCore/PAL/pal/spi/cocoa/LaunchServicesSPI.h  2021-12-10 22:19:03 UTC (rev 286878)
</span><span class="lines">@@ -50,6 +50,9 @@
</span><span class="cx"> WTF_EXTERN_C_END
</span><span class="cx"> #endif // PLATFORM(MACCATALYST)
</span><span class="cx"> #else // USE(APPLE_INTERNAL_SDK)
</span><ins>+
+const uint8_t kLSOpenRunningInstanceBehaviorUseRunningProcess = 1;
+
</ins><span class="cx"> @interface LSResourceProxy : NSObject <NSCopying, NSSecureCoding>
</span><span class="cx"> @property (nonatomic, copy, readonly) NSString *localizedName;
</span><span class="cx"> @end
</span><span class="lines">@@ -130,6 +133,11 @@
</span><span class="cx"> WTF_EXTERN_C_BEGIN
</span><span class="cx"> 
</span><span class="cx"> extern const CFStringRef _kLSDisplayNameKey;
</span><ins>+extern const CFStringRef _kLSOpenOptionActivateKey;
+extern const CFStringRef _kLSOpenOptionAddToRecentsKey;
+extern const CFStringRef _kLSOpenOptionBackgroundLaunchKey;
+extern const CFStringRef _kLSOpenOptionHideKey;
+extern const CFStringRef _kLSOpenOptionPreferRunningInstanceKey;
</ins><span class="cx"> extern const CFStringRef _kLSPersistenceSuppressRelaunchAtLoginKey;
</span><span class="cx"> 
</span><span class="cx"> LSASNRef _LSGetCurrentApplicationASN();
</span><span class="lines">@@ -139,6 +147,9 @@
</span><span class="cx"> 
</span><span class="cx"> OSStatus _RegisterApplication(CFDictionaryRef, ProcessSerialNumber*);
</span><span class="cx"> 
</span><ins>+typedef void (^ _LSOpenCompletionHandler)(LSASNRef, Boolean, CFErrorRef);
+void _LSOpenURLsUsingBundleIdentifierWithCompletionHandler(CFArrayRef, CFStringRef, CFDictionaryRef, _LSOpenCompletionHandler);
+
</ins><span class="cx"> WTF_EXTERN_C_END
</span><span class="cx"> 
</span><span class="cx"> #endif // PLATFORM(MAC)
</span></span></pre></div>
<a id="trunkSourceWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ChangeLog (286877 => 286878)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ChangeLog    2021-12-10 22:17:27 UTC (rev 286877)
+++ trunk/Source/WebKit/ChangeLog       2021-12-10 22:19:03 UTC (rev 286878)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2021-12-10  Brady Eidson  <beidson@apple.com>
+
+        Teach webpushd to launch an app in response to an injected message.
+        https://bugs.webkit.org/show_bug.cgi?id=234122
+
+        Reviewed by Alex Christensen.
+
+        To by covered by future API test.
+
+        When a message comes in, webpushd knows which code signing identifier it was targetted for.
+        It launches that app in a special mode so the app can then "take it from there"
+        
+        * webpushd/WebPushDaemon.h:
+        * webpushd/WebPushDaemon.mm:
+        (WebPushD::Daemon::injectPushMessageForTesting):
+        (WebPushD::Daemon::notifyClientPushMessageIsAvailable):
+        
</ins><span class="cx"> 2021-12-10  Antoine Quint  <graouts@webkit.org>
</span><span class="cx"> 
</span><span class="cx">         Expose the maximum device frame rate to the Web Animations model
</span></span></pre></div>
<a id="trunkSourceWebKitwebpushdWebPushDaemonh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/webpushd/WebPushDaemon.h (286877 => 286878)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/webpushd/WebPushDaemon.h     2021-12-10 22:17:27 UTC (rev 286877)
+++ trunk/Source/WebKit/webpushd/WebPushDaemon.h        2021-12-10 22:19:03 UTC (rev 286878)
</span><span class="lines">@@ -79,6 +79,8 @@
</span><span class="cx"> 
</span><span class="cx">     bool canRegisterForNotifications(ClientConnection&);
</span><span class="cx"> 
</span><ins>+    void notifyClientPushMessageIsAvailable(const String& clientCodeSigningIdentifier);
+
</ins><span class="cx">     ClientConnection* toClientConnection(xpc_connection_t);
</span><span class="cx">     HashMap<xpc_connection_t, Ref<ClientConnection>> m_connectionMap;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKitwebpushdWebPushDaemonmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/webpushd/WebPushDaemon.mm (286877 => 286878)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/webpushd/WebPushDaemon.mm    2021-12-10 22:17:27 UTC (rev 286877)
+++ trunk/Source/WebKit/webpushd/WebPushDaemon.mm       2021-12-10 22:19:03 UTC (rev 286878)
</span><span class="lines">@@ -33,6 +33,7 @@
</span><span class="cx"> #import "HandleMessage.h"
</span><span class="cx"> #import "MockAppBundleRegistry.h"
</span><span class="cx"> 
</span><ins>+#import <pal/spi/cocoa/LaunchServicesSPI.h>
</ins><span class="cx"> #import <wtf/CompletionHandler.h>
</span><span class="cx"> #import <wtf/HexNumber.h>
</span><span class="cx"> #import <wtf/NeverDestroyed.h>
</span><span class="lines">@@ -349,9 +350,32 @@
</span><span class="cx">     });
</span><span class="cx">     addResult.iterator->value.append(message);
</span><span class="cx"> 
</span><ins>+    notifyClientPushMessageIsAvailable(message.targetAppCodeSigningIdentifier);
+
</ins><span class="cx">     replySender(true);
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+void Daemon::notifyClientPushMessageIsAvailable(const String& clientCodeSigningIdentifier)
+{
+#if PLATFORM(MAC)
+    CFArrayRef urls = (__bridge CFArrayRef)@[ [NSURL URLWithString:@"webkit-app-launch://1"] ];
+    CFStringRef identifier = (__bridge CFStringRef)((NSString *)clientCodeSigningIdentifier);
+
+    CFDictionaryRef options = (__bridge CFDictionaryRef)@{
+        (id)_kLSOpenOptionPreferRunningInstanceKey: @(kLSOpenRunningInstanceBehaviorUseRunningProcess),
+        (id)_kLSOpenOptionActivateKey: @NO,
+        (id)_kLSOpenOptionAddToRecentsKey: @NO,
+        (id)_kLSOpenOptionBackgroundLaunchKey: @YES,
+        (id)_kLSOpenOptionHideKey: @YES,
+    };
+
+    _LSOpenURLsUsingBundleIdentifierWithCompletionHandler(urls, identifier, options, ^(LSASNRef newProcessSerialNumber, Boolean processWasLaunched, CFErrorRef cfError) { });
+#else
+    // FIXME: Figure out equivalent iOS code here
+    UNUSED_PARAM(clientCodeSigningIdentifier);
+#endif // PLATFORM(MAC)
+}
+
</ins><span class="cx"> void Daemon::getPendingPushMessages(ClientConnection* connection, CompletionHandler<void(const Vector<WebKit::WebPushMessage>&)>&& replySender)
</span><span class="cx"> {
</span><span class="cx">     auto hostAppCodeSigningIdentifier = connection->hostAppCodeSigningIdentifier();
</span></span></pre>
</div>
</div>

</body>
</html>