<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[286803] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/286803">286803</a></dd>
<dt>Author</dt> <dd>bfulgham@apple.com</dd>
<dt>Date</dt> <dd>2021-12-09 14:47:24 -0800 (Thu, 09 Dec 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Unprefix CSS value text-align: -webkit-match-parent
https://bugs.webkit.org/show_bug.cgi?id=229496
<rdar://problem/82628618>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline to show new passing tests.

* web-platform-tests/css/css-text/parsing/text-align-computed-expected.txt:
* web-platform-tests/css/css-text/parsing/text-align-valid-expected.txt:

Source/WebCore:

Tested by web-platform-tests: css/css-text/parsing/text-align-computed.html,
    css/css-text/parsing/text-align-valid.html

SSIA.

* css/CSSProperties.json: Add the unprefixed version.
* css/CSSValueKeywords.in: Ditto.
* css/html.css:
(li): Use the unprefixed version.
* style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertTextAlign): Handle the new unprefixed version.

Source/WebInspectorUI:

* UserInterface/Models/CSSKeywordCompletions.js: Add 'match-parent'</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestscsscsstextparsingtextaligncomputedexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-align-computed-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestscsscsstextparsingtextalignvalidexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-align-valid-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssCSSPropertiesjson">trunk/Source/WebCore/css/CSSProperties.json</a></li>
<li><a href="#trunkSourceWebCorecssCSSValueKeywordsin">trunk/Source/WebCore/css/CSSValueKeywords.in</a></li>
<li><a href="#trunkSourceWebCorecsshtmlcss">trunk/Source/WebCore/css/html.css</a></li>
<li><a href="#trunkSourceWebCorestyleStyleBuilderConverterh">trunk/Source/WebCore/style/StyleBuilderConverter.h</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceModelsCSSKeywordCompletionsjs">trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (286802 => 286803)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-12-09 21:49:45 UTC (rev 286802)
+++ trunk/LayoutTests/imported/w3c/ChangeLog    2021-12-09 22:47:24 UTC (rev 286803)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2021-12-09  Brent Fulgham  <bfulgham@apple.com>
+
+        Unprefix CSS value text-align: -webkit-match-parent
+        https://bugs.webkit.org/show_bug.cgi?id=229496
+        <rdar://problem/82628618>
+
+        Reviewed by Darin Adler.
+
+        Rebaseline to show new passing tests.
+
+        * web-platform-tests/css/css-text/parsing/text-align-computed-expected.txt:
+        * web-platform-tests/css/css-text/parsing/text-align-valid-expected.txt:
+
</ins><span class="cx"> 2021-12-09  Matt Woodrow  <matt.woodrow@gmail.com>
</span><span class="cx"> 
</span><span class="cx">         Unprefix -webkit-mask
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestscsscsstextparsingtextaligncomputedexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-align-computed-expected.txt (286802 => 286803)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-align-computed-expected.txt  2021-12-09 21:49:45 UTC (rev 286802)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-align-computed-expected.txt     2021-12-09 22:47:24 UTC (rev 286803)
</span><span class="lines">@@ -5,5 +5,5 @@
</span><span class="cx"> PASS Property text-align value 'right'
</span><span class="cx"> PASS Property text-align value 'center'
</span><span class="cx"> PASS Property text-align value 'justify'
</span><del>-FAIL Property text-align value 'match-parent' assert_true: 'match-parent' is a supported value for text-align. expected true got false
</del><ins>+PASS Property text-align value 'match-parent'
</ins><span class="cx"> 
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestscsscsstextparsingtextalignvalidexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-align-valid-expected.txt (286802 => 286803)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-align-valid-expected.txt     2021-12-09 21:49:45 UTC (rev 286802)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-align-valid-expected.txt        2021-12-09 22:47:24 UTC (rev 286803)
</span><span class="lines">@@ -5,6 +5,6 @@
</span><span class="cx"> PASS e.style['text-align'] = "right" should set the property value
</span><span class="cx"> PASS e.style['text-align'] = "center" should set the property value
</span><span class="cx"> PASS e.style['text-align'] = "justify" should set the property value
</span><del>-FAIL e.style['text-align'] = "match-parent" should set the property value assert_not_equals: property should be set got disallowed value ""
</del><ins>+PASS e.style['text-align'] = "match-parent" should set the property value
</ins><span class="cx"> FAIL e.style['text-align'] = "justify-all" should set the property value assert_not_equals: property should be set got disallowed value ""
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (286802 => 286803)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2021-12-09 21:49:45 UTC (rev 286802)
+++ trunk/Source/WebCore/ChangeLog      2021-12-09 22:47:24 UTC (rev 286803)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2021-12-09  Brent Fulgham  <bfulgham@apple.com>
+
+        Unprefix CSS value text-align: -webkit-match-parent
+        https://bugs.webkit.org/show_bug.cgi?id=229496
+        <rdar://problem/82628618>
+
+        Reviewed by Darin Adler.
+
+        Tested by web-platform-tests: css/css-text/parsing/text-align-computed.html,
+            css/css-text/parsing/text-align-valid.html 
+
+        SSIA.
+
+        * css/CSSProperties.json: Add the unprefixed version.
+        * css/CSSValueKeywords.in: Ditto.
+        * css/html.css:
+        (li): Use the unprefixed version.
+        * style/StyleBuilderConverter.h:
+        (WebCore::Style::BuilderConverter::convertTextAlign): Handle the new unprefixed version.
+
</ins><span class="cx"> 2021-12-09  Alan Bujtas  <zalan@apple.com>
</span><span class="cx"> 
</span><span class="cx">         [LFC][IFC] Try not to include non-content type of inline boxes in the visual reordering
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSPropertiesjson"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSProperties.json (286802 => 286803)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSProperties.json      2021-12-09 21:49:45 UTC (rev 286802)
+++ trunk/Source/WebCore/css/CSSProperties.json 2021-12-09 22:47:24 UTC (rev 286803)
</span><span class="lines">@@ -4501,12 +4501,16 @@
</span><span class="cx">                 "right",
</span><span class="cx">                 "center",
</span><span class="cx">                 "justify",
</span><ins>+                {
+                    "value": "match-parent",
+                    "url": "https://www.w3.org/TR/css-text-3/#text-align"
+                },
</ins><span class="cx">                 "-webkit-left",
</span><span class="cx">                 "-webkit-right",
</span><span class="cx">                 "-webkit-center",
</span><span class="cx">                 {
</span><span class="cx">                     "value": "-webkit-match-parent",
</span><del>-                    "url": "https://www.w3.org/TR/css-text-3/#text-align"
</del><ins>+                    "url": "non-standard"
</ins><span class="cx">                 },
</span><span class="cx">                 {
</span><span class="cx">                     "value": "start",
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSValueKeywordsin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSValueKeywords.in (286802 => 286803)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSValueKeywords.in     2021-12-09 21:49:45 UTC (rev 286802)
+++ trunk/Source/WebCore/css/CSSValueKeywords.in        2021-12-09 22:47:24 UTC (rev 286803)
</span><span class="lines">@@ -342,7 +342,10 @@
</span><span class="cx"> -webkit-left
</span><span class="cx"> -webkit-right
</span><span class="cx"> -webkit-center
</span><ins>+match-parent
</ins><span class="cx"> -webkit-match-parent
</span><ins>+//start
+//end
</ins><span class="cx"> //
</span><span class="cx"> // CSS_PROP_TEXT_JUSTIFY:
</span><span class="cx"> //
</span></span></pre></div>
<a id="trunkSourceWebCorecsshtmlcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/html.css (286802 => 286803)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/html.css        2021-12-09 21:49:45 UTC (rev 286802)
+++ trunk/Source/WebCore/css/html.css   2021-12-09 22:47:24 UTC (rev 286803)
</span><span class="lines">@@ -299,7 +299,7 @@
</span><span class="cx"> 
</span><span class="cx"> li {
</span><span class="cx">     display: list-item;
</span><del>-    text-align: -webkit-match-parent;
</del><ins>+    text-align: match-parent;
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> /* FIXME: this should also match ::before::marker and ::after::marker but we don't support
</span></span></pre></div>
<a id="trunkSourceWebCorestyleStyleBuilderConverterh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/style/StyleBuilderConverter.h (286802 => 286803)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/style/StyleBuilderConverter.h       2021-12-09 21:49:45 UTC (rev 286802)
+++ trunk/Source/WebCore/style/StyleBuilderConverter.h  2021-12-09 22:47:24 UTC (rev 286803)
</span><span class="lines">@@ -612,7 +612,7 @@
</span><span class="cx">     auto& primitiveValue = downcast<CSSPrimitiveValue>(value);
</span><span class="cx">     ASSERT(primitiveValue.isValueID());
</span><span class="cx"> 
</span><del>-    if (primitiveValue.valueID() != CSSValueWebkitMatchParent)
</del><ins>+    if (primitiveValue.valueID() != CSSValueWebkitMatchParent && primitiveValue.valueID() != CSSValueMatchParent)
</ins><span class="cx">         return primitiveValue;
</span><span class="cx"> 
</span><span class="cx">     auto& parentStyle = builderState.parentStyle();
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (286802 => 286803)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog    2021-12-09 21:49:45 UTC (rev 286802)
+++ trunk/Source/WebInspectorUI/ChangeLog       2021-12-09 22:47:24 UTC (rev 286803)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2021-12-09  Brent Fulgham  <bfulgham@apple.com>
+
+        Unprefix CSS value text-align: -webkit-match-parent
+        https://bugs.webkit.org/show_bug.cgi?id=229496
+        <rdar://problem/82628618>
+
+        Reviewed by Darin Adler.
+
+        * UserInterface/Models/CSSKeywordCompletions.js: Add 'match-parent'
+
</ins><span class="cx"> 2021-12-08  BJ Burg  <bburg@apple.com>
</span><span class="cx"> 
</span><span class="cx">         [Cocoa] Web Inspector: provide a way for _WKInspectorExtension clients to be to notified when an extension tab navigates
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceModelsCSSKeywordCompletionsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js (286802 => 286803)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js        2021-12-09 21:49:45 UTC (rev 286802)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js   2021-12-09 22:47:24 UTC (rev 286803)
</span><span class="lines">@@ -1346,7 +1346,7 @@
</span><span class="cx">         "auto", "fixed",
</span><span class="cx">     ],
</span><span class="cx">     "text-align": [
</span><del>-        "-webkit-auto", "left", "right", "center", "justify", "-webkit-left", "-webkit-right", "-webkit-center", "-webkit-match-parent", "start", "end",
</del><ins>+        "-webkit-auto", "left", "right", "center", "justify", "match-parent", "-webkit-left", "-webkit-right", "-webkit-center", "-webkit-match-parent", "start", "end",
</ins><span class="cx">     ],
</span><span class="cx">     "text-anchor": [
</span><span class="cx">         "middle", "start", "end",
</span></span></pre>
</div>
</div>

</body>
</html>