<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[286537] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/286537">286537</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2021-12-05 20:40:19 -0800 (Sun, 05 Dec 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Add trace points for generated momentum events
https://bugs.webkit.org/show_bug.cgi?id=233857

Reviewed by Tim Horton.

Source/WebKit:

Add start/end points for synthetic momentum, and a trace point for each generated event.

* WebProcess/WebPage/MomentumEventDispatcher.cpp:
(WebKit::MomentumEventDispatcher::dispatchSyntheticMomentumEvent):
(WebKit::MomentumEventDispatcher::didStartMomentumPhase):
(WebKit::MomentumEventDispatcher::didEndMomentumPhase):

Source/WTF:

* wtf/SystemTracing.h:

Tools:

Add start/end points for synthetic momentum, and a trace point for each generated event.

* Tracing/SystemTracePoints.plist:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfSystemTracingh">trunk/Source/WTF/wtf/SystemTracing.h</a></li>
<li><a href="#trunkSourceWebKitChangeLog">trunk/Source/WebKit/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitWebProcessWebPageMomentumEventDispatchercpp">trunk/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTracingSystemTracePointsplist">trunk/Tools/Tracing/SystemTracePoints.plist</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (286536 => 286537)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog       2021-12-05 04:14:50 UTC (rev 286536)
+++ trunk/Source/WTF/ChangeLog  2021-12-06 04:40:19 UTC (rev 286537)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2021-12-05  Simon Fraser  <simon.fraser@apple.com>
+
+        Add trace points for generated momentum events
+        https://bugs.webkit.org/show_bug.cgi?id=233857
+
+        Reviewed by Tim Horton.
+
+        * wtf/SystemTracing.h:
+
</ins><span class="cx"> 2021-12-03  Chris Dumez  <cdumez@apple.com>
</span><span class="cx"> 
</span><span class="cx">         [WK2] Turn on Web Locks API support
</span></span></pre></div>
<a id="trunkSourceWTFwtfSystemTracingh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/SystemTracing.h (286536 => 286537)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/SystemTracing.h     2021-12-05 04:14:50 UTC (rev 286536)
+++ trunk/Source/WTF/wtf/SystemTracing.h        2021-12-06 04:40:19 UTC (rev 286537)
</span><span class="lines">@@ -127,6 +127,9 @@
</span><span class="cx">     RenderServerSnapshotEnd,
</span><span class="cx">     TakeSnapshotStart,
</span><span class="cx">     TakeSnapshotEnd,
</span><ins>+    SyntheticMomentumStart,
+    SyntheticMomentumEnd,
+    SyntheticMomentumEvent,
</ins><span class="cx"> 
</span><span class="cx">     UIProcessRange = 14000,
</span><span class="cx">     CommitLayerTreeStart,
</span></span></pre></div>
<a id="trunkSourceWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ChangeLog (286536 => 286537)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ChangeLog    2021-12-05 04:14:50 UTC (rev 286536)
+++ trunk/Source/WebKit/ChangeLog       2021-12-06 04:40:19 UTC (rev 286537)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2021-12-05  Simon Fraser  <simon.fraser@apple.com>
+
+        Add trace points for generated momentum events
+        https://bugs.webkit.org/show_bug.cgi?id=233857
+
+        Reviewed by Tim Horton.
+
+        Add start/end points for synthetic momentum, and a trace point for each generated event.
+
+        * WebProcess/WebPage/MomentumEventDispatcher.cpp:
+        (WebKit::MomentumEventDispatcher::dispatchSyntheticMomentumEvent):
+        (WebKit::MomentumEventDispatcher::didStartMomentumPhase):
+        (WebKit::MomentumEventDispatcher::didEndMomentumPhase):
+
</ins><span class="cx"> 2021-12-04  Myles C. Maxfield  <mmaxfield@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Rename DerivedSources/WebKit2 to DerivedSources/WebKit
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcessWebPageMomentumEventDispatchercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp (286536 => 286537)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp       2021-12-05 04:14:50 UTC (rev 286536)
+++ trunk/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp  2021-12-06 04:40:19 UTC (rev 286537)
</span><span class="lines">@@ -34,6 +34,7 @@
</span><span class="cx"> #include "WebProcessProxyMessages.h"
</span><span class="cx"> #include <WebCore/DisplayRefreshMonitor.h>
</span><span class="cx"> #include <WebCore/Scrollbar.h>
</span><ins>+#include <wtf/SystemTracing.h>
</ins><span class="cx"> 
</span><span class="cx"> namespace WebKit {
</span><span class="cx"> 
</span><span class="lines">@@ -144,6 +145,8 @@
</span><span class="cx"> 
</span><span class="cx"> void MomentumEventDispatcher::dispatchSyntheticMomentumEvent(WebWheelEvent::Phase phase, WebCore::FloatSize delta)
</span><span class="cx"> {
</span><ins>+    tracePoint(SyntheticMomentumEvent, static_cast<uint64_t>(phase), std::abs(delta.width()), std::abs(delta.height()));
+
</ins><span class="cx">     ASSERT(m_currentGesture.active);
</span><span class="cx">     ASSERT(m_currentGesture.initiatingEvent);
</span><span class="cx"> 
</span><span class="lines">@@ -182,6 +185,8 @@
</span><span class="cx"> 
</span><span class="cx"> void MomentumEventDispatcher::didStartMomentumPhase(WebCore::PageIdentifier pageIdentifier, const WebWheelEvent& event)
</span><span class="cx"> {
</span><ins>+    tracePoint(SyntheticMomentumStart);
+
</ins><span class="cx">     auto momentumStartInterval = event.ioHIDEventTimestamp() - m_lastEndedEventTimestamp;
</span><span class="cx"> 
</span><span class="cx">     m_currentGesture.active = true;
</span><span class="lines">@@ -223,6 +228,7 @@
</span><span class="cx">     stopDisplayLink();
</span><span class="cx"> 
</span><span class="cx">     m_currentGesture = { };
</span><ins>+    tracePoint(SyntheticMomentumEnd);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void MomentumEventDispatcher::setScrollingAccelerationCurve(WebCore::PageIdentifier pageIdentifier, std::optional<ScrollingAccelerationCurve> curve)
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (286536 => 286537)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog    2021-12-05 04:14:50 UTC (rev 286536)
+++ trunk/Tools/ChangeLog       2021-12-06 04:40:19 UTC (rev 286537)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2021-12-05  Simon Fraser  <simon.fraser@apple.com>
+
+        Add trace points for generated momentum events
+        https://bugs.webkit.org/show_bug.cgi?id=233857
+
+        Reviewed by Tim Horton.
+
+        Add start/end points for synthetic momentum, and a trace point for each generated event.
+
+        * Tracing/SystemTracePoints.plist:
+
</ins><span class="cx"> 2021-12-04  Andres Gonzalez  <andresg_22@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Change WTR::AccessibilityUIElement::descriptionOfValue(id) to return a RetainPtr.
</span></span></pre></div>
<a id="trunkToolsTracingSystemTracePointsplist"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Tracing/SystemTracePoints.plist (286536 => 286537)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Tracing/SystemTracePoints.plist      2021-12-05 04:14:50 UTC (rev 286536)
+++ trunk/Tools/Tracing/SystemTracePoints.plist 2021-12-06 04:40:19 UTC (rev 286537)
</span><span class="lines">@@ -596,6 +596,48 @@
</span><span class="cx">              </dict>
</span><span class="cx">              <dict>
</span><span class="cx">                  <key>Name</key>
</span><ins>+                 <string>Synthetic momentum</string>
+                 <key>Type</key>
+                 <string>Interval</string>
+                 <key>Component</key>
+                 <string>47</string>
+                 <key>CodeBegin</key>
+                 <string>12025</string>
+                 <key>CodeEnd</key>
+                 <string>12026</string>
+                 <key>ArgNamesEnd</key>
+                 <dict>
+                     <key>Arg1</key>
+                     <string>Initial Velocity X</string>
+                     <key>Arg2</key>
+                     <string>Initial Velocity Y</string>
+                 </dict>
+             </dict>
+             <dict>
+                 <key>Name</key>
+                 <string>Synthetic momentum event</string>
+                 <key>Type</key>
+                 <string>Level</string>
+                 <key>Component</key>
+                 <string>47</string>
+                 <key>Code</key>
+                 <string>12027</string>
+                 <key>ArgNames</key>
+                 <dict>
+                     <key>Arg1</key>
+                     <string>Phase</string>
+                     <key>Arg2</key>
+                     <string>Delta X</string>
+                     <key>Arg3</key>
+                     <string>Delta Y</string>
+                 </dict>
+                 <key>LevelArg</key>
+                 <string>Arg3</string>
+                 <key>LevelDataType</key>
+                 <string>UInt64</string>
+             </dict>
+             <dict>
+                 <key>Name</key>
</ins><span class="cx">                  <string>Commit RemoteLayerTree transaction</string>
</span><span class="cx">                  <key>Type</key>
</span><span class="cx">                  <string>Interval</string>
</span></span></pre>
</div>
</div>

</body>
</html>