<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[286447] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/286447">286447</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2021-12-02 13:13:02 -0800 (Thu, 02 Dec 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Remove the multipart parameter to FormAssociatedElement::appendFormData, InputType::appendFormData and HTMLFormElement::constructEntryList
https://bugs.webkit.org/show_bug.cgi?id=233774

Patch by Andreu Botella <andreu@andreubotella.com> on 2021-12-02
Reviewed by Chris Dumez.

These parameters were only needed because of an optimization where file inputs were being
added to the DOMFormData as string values containing their filenames if the entry list was
being constructed to be used in a urlencoded or text/plain form submission. This
optimization was removed in <a href="http://trac.webkit.org/projects/webkit/changeset/286427">r286427</a> and those parameters can now be dropped.

No behavior change.

* html/BaseButtonInputType.cpp:
(WebCore::BaseButtonInputType::appendFormData const):
* html/BaseButtonInputType.h:
* html/BaseCheckableInputType.cpp:
(WebCore::BaseCheckableInputType::appendFormData const):
* html/BaseCheckableInputType.h:
* html/DOMFormData.cpp:
(WebCore::DOMFormData::create):
* html/FileInputType.cpp:
(WebCore::FileInputType::appendFormData const):
* html/FileInputType.h:
* html/FormAssociatedElement.h:
(WebCore::FormAssociatedElement::appendFormData):
* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::appendFormData):
* html/HTMLButtonElement.h:
* html/HTMLFormControlElement.h:
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::constructEntryList):
* html/HTMLFormElement.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::appendFormData):
* html/HTMLInputElement.h:
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::appendFormData):
* html/HTMLKeygenElement.h:
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::appendFormData):
* html/HTMLObjectElement.h:
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::appendFormData):
* html/HTMLSelectElement.h:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::appendFormData):
* html/HTMLTextAreaElement.h:
* html/HiddenInputType.cpp:
(WebCore::HiddenInputType::appendFormData const):
* html/HiddenInputType.h:
* html/ImageInputType.cpp:
(WebCore::ImageInputType::appendFormData const):
* html/ImageInputType.h:
* html/InputType.cpp:
(WebCore::InputType::appendFormData const):
* html/InputType.h:
* html/SubmitInputType.cpp:
(WebCore::SubmitInputType::appendFormData const):
* html/SubmitInputType.h:
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::appendFormData const):
* html/TextFieldInputType.h:
* loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlBaseButtonInputTypecpp">trunk/Source/WebCore/html/BaseButtonInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlBaseButtonInputTypeh">trunk/Source/WebCore/html/BaseButtonInputType.h</a></li>
<li><a href="#trunkSourceWebCorehtmlBaseCheckableInputTypecpp">trunk/Source/WebCore/html/BaseCheckableInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlBaseCheckableInputTypeh">trunk/Source/WebCore/html/BaseCheckableInputType.h</a></li>
<li><a href="#trunkSourceWebCorehtmlDOMFormDatacpp">trunk/Source/WebCore/html/DOMFormData.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlFileInputTypecpp">trunk/Source/WebCore/html/FileInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlFileInputTypeh">trunk/Source/WebCore/html/FileInputType.h</a></li>
<li><a href="#trunkSourceWebCorehtmlFormAssociatedElementh">trunk/Source/WebCore/html/FormAssociatedElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLButtonElementcpp">trunk/Source/WebCore/html/HTMLButtonElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLButtonElementh">trunk/Source/WebCore/html/HTMLButtonElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFormControlElementh">trunk/Source/WebCore/html/HTMLFormControlElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFormElementcpp">trunk/Source/WebCore/html/HTMLFormElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFormElementh">trunk/Source/WebCore/html/HTMLFormElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLInputElementcpp">trunk/Source/WebCore/html/HTMLInputElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLInputElementh">trunk/Source/WebCore/html/HTMLInputElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLKeygenElementcpp">trunk/Source/WebCore/html/HTMLKeygenElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLKeygenElementh">trunk/Source/WebCore/html/HTMLKeygenElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLObjectElementcpp">trunk/Source/WebCore/html/HTMLObjectElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLObjectElementh">trunk/Source/WebCore/html/HTMLObjectElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLSelectElementcpp">trunk/Source/WebCore/html/HTMLSelectElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLSelectElementh">trunk/Source/WebCore/html/HTMLSelectElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTextAreaElementcpp">trunk/Source/WebCore/html/HTMLTextAreaElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTextAreaElementh">trunk/Source/WebCore/html/HTMLTextAreaElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHiddenInputTypecpp">trunk/Source/WebCore/html/HiddenInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHiddenInputTypeh">trunk/Source/WebCore/html/HiddenInputType.h</a></li>
<li><a href="#trunkSourceWebCorehtmlImageInputTypecpp">trunk/Source/WebCore/html/ImageInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlImageInputTypeh">trunk/Source/WebCore/html/ImageInputType.h</a></li>
<li><a href="#trunkSourceWebCorehtmlInputTypecpp">trunk/Source/WebCore/html/InputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlInputTypeh">trunk/Source/WebCore/html/InputType.h</a></li>
<li><a href="#trunkSourceWebCorehtmlSubmitInputTypecpp">trunk/Source/WebCore/html/SubmitInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlSubmitInputTypeh">trunk/Source/WebCore/html/SubmitInputType.h</a></li>
<li><a href="#trunkSourceWebCorehtmlTextFieldInputTypecpp">trunk/Source/WebCore/html/TextFieldInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlTextFieldInputTypeh">trunk/Source/WebCore/html/TextFieldInputType.h</a></li>
<li><a href="#trunkSourceWebCoreloaderFormSubmissioncpp">trunk/Source/WebCore/loader/FormSubmission.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/ChangeLog      2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -1,3 +1,70 @@
</span><ins>+2021-12-02  Andreu Botella  <andreu@andreubotella.com>
+
+        Remove the multipart parameter to FormAssociatedElement::appendFormData, InputType::appendFormData and HTMLFormElement::constructEntryList
+        https://bugs.webkit.org/show_bug.cgi?id=233774
+
+        Reviewed by Chris Dumez.
+
+        These parameters were only needed because of an optimization where file inputs were being
+        added to the DOMFormData as string values containing their filenames if the entry list was
+        being constructed to be used in a urlencoded or text/plain form submission. This
+        optimization was removed in r286427 and those parameters can now be dropped.
+
+        No behavior change.
+
+        * html/BaseButtonInputType.cpp:
+        (WebCore::BaseButtonInputType::appendFormData const):
+        * html/BaseButtonInputType.h:
+        * html/BaseCheckableInputType.cpp:
+        (WebCore::BaseCheckableInputType::appendFormData const):
+        * html/BaseCheckableInputType.h:
+        * html/DOMFormData.cpp:
+        (WebCore::DOMFormData::create):
+        * html/FileInputType.cpp:
+        (WebCore::FileInputType::appendFormData const):
+        * html/FileInputType.h:
+        * html/FormAssociatedElement.h:
+        (WebCore::FormAssociatedElement::appendFormData):
+        * html/HTMLButtonElement.cpp:
+        (WebCore::HTMLButtonElement::appendFormData):
+        * html/HTMLButtonElement.h:
+        * html/HTMLFormControlElement.h:
+        * html/HTMLFormElement.cpp:
+        (WebCore::HTMLFormElement::constructEntryList):
+        * html/HTMLFormElement.h:
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::appendFormData):
+        * html/HTMLInputElement.h:
+        * html/HTMLKeygenElement.cpp:
+        (WebCore::HTMLKeygenElement::appendFormData):
+        * html/HTMLKeygenElement.h:
+        * html/HTMLObjectElement.cpp:
+        (WebCore::HTMLObjectElement::appendFormData):
+        * html/HTMLObjectElement.h:
+        * html/HTMLSelectElement.cpp:
+        (WebCore::HTMLSelectElement::appendFormData):
+        * html/HTMLSelectElement.h:
+        * html/HTMLTextAreaElement.cpp:
+        (WebCore::HTMLTextAreaElement::appendFormData):
+        * html/HTMLTextAreaElement.h:
+        * html/HiddenInputType.cpp:
+        (WebCore::HiddenInputType::appendFormData const):
+        * html/HiddenInputType.h:
+        * html/ImageInputType.cpp:
+        (WebCore::ImageInputType::appendFormData const):
+        * html/ImageInputType.h:
+        * html/InputType.cpp:
+        (WebCore::InputType::appendFormData const):
+        * html/InputType.h:
+        * html/SubmitInputType.cpp:
+        (WebCore::SubmitInputType::appendFormData const):
+        * html/SubmitInputType.h:
+        * html/TextFieldInputType.cpp:
+        (WebCore::TextFieldInputType::appendFormData const):
+        * html/TextFieldInputType.h:
+        * loader/FormSubmission.cpp:
+        (WebCore::FormSubmission::create):
+
</ins><span class="cx"> 2021-12-02  Alan Bujtas  <zalan@apple.com>
</span><span class="cx"> 
</span><span class="cx">         [LFC][IFC] Introduce createDisplayBoxesInVisualOrderForContentRuns
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlBaseButtonInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/BaseButtonInputType.cpp (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/BaseButtonInputType.cpp        2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/BaseButtonInputType.cpp   2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -45,7 +45,7 @@
</span><span class="cx">     return false;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-bool BaseButtonInputType::appendFormData(DOMFormData&, bool) const
</del><ins>+bool BaseButtonInputType::appendFormData(DOMFormData&) const
</ins><span class="cx"> {
</span><span class="cx">     // Buttons except overridden types are never successful.
</span><span class="cx">     return false;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlBaseButtonInputTypeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/BaseButtonInputType.h (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/BaseButtonInputType.h  2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/BaseButtonInputType.h     2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx"> 
</span><span class="cx"> private:
</span><span class="cx">     bool shouldSaveAndRestoreFormControlState() const override;
</span><del>-    bool appendFormData(DOMFormData&, bool) const override;
</del><ins>+    bool appendFormData(DOMFormData&) const override;
</ins><span class="cx">     RenderPtr<RenderElement> createInputRenderer(RenderStyle&&) override;
</span><span class="cx">     bool storesValueSeparateFromAttribute() override;
</span><span class="cx">     void setValue(const String&, bool, TextFieldEventBehavior) override;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlBaseCheckableInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/BaseCheckableInputType.cpp (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/BaseCheckableInputType.cpp     2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/BaseCheckableInputType.cpp        2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -55,7 +55,7 @@
</span><span class="cx">     element()->setChecked(state[0] == "on");
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-bool BaseCheckableInputType::appendFormData(DOMFormData& formData, bool) const
</del><ins>+bool BaseCheckableInputType::appendFormData(DOMFormData& formData) const
</ins><span class="cx"> {
</span><span class="cx">     ASSERT(element());
</span><span class="cx">     if (!element()->checked())
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlBaseCheckableInputTypeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/BaseCheckableInputType.h (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/BaseCheckableInputType.h       2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/BaseCheckableInputType.h  2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -44,7 +44,7 @@
</span><span class="cx"> private:
</span><span class="cx">     FormControlState saveFormControlState() const override;
</span><span class="cx">     void restoreFormControlState(const FormControlState&) override;
</span><del>-    bool appendFormData(DOMFormData&, bool) const override;
</del><ins>+    bool appendFormData(DOMFormData&) const override;
</ins><span class="cx">     void handleKeypressEvent(KeyboardEvent&) override;
</span><span class="cx">     bool canSetStringValue() const override;
</span><span class="cx">     bool accessKeyAction(bool sendMouseEvents) override;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlDOMFormDatacpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/DOMFormData.cpp (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/DOMFormData.cpp        2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/DOMFormData.cpp   2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx">     if (!form)
</span><span class="cx">         return formData;
</span><span class="cx">     
</span><del>-    auto result = form->constructEntryList(WTFMove(formData), nullptr, HTMLFormElement::IsMultipartForm::Yes);
</del><ins>+    auto result = form->constructEntryList(WTFMove(formData), nullptr);
</ins><span class="cx">     
</span><span class="cx">     if (!result)
</span><span class="cx">         return Exception { InvalidStateError, "Already constructing Form entry list."_s };
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlFileInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/FileInputType.cpp (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/FileInputType.cpp      2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/FileInputType.cpp 2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -158,7 +158,7 @@
</span><span class="cx">     filesChosen(filesFromFormControlState(state));
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-bool FileInputType::appendFormData(DOMFormData& formData, bool) const
</del><ins>+bool FileInputType::appendFormData(DOMFormData& formData) const
</ins><span class="cx"> {
</span><span class="cx">     ASSERT(element());
</span><span class="cx">     RefPtr fileList = element()->files();
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlFileInputTypeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/FileInputType.h (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/FileInputType.h        2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/FileInputType.h   2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -56,7 +56,7 @@
</span><span class="cx">     const AtomString& formControlType() const final;
</span><span class="cx">     FormControlState saveFormControlState() const final;
</span><span class="cx">     void restoreFormControlState(const FormControlState&) final;
</span><del>-    bool appendFormData(DOMFormData&, bool) const final;
</del><ins>+    bool appendFormData(DOMFormData&) const final;
</ins><span class="cx">     bool valueMissing(const String&) const final;
</span><span class="cx">     String valueMissingText() const final;
</span><span class="cx">     void handleDOMActivateEvent(Event&) final;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlFormAssociatedElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/FormAssociatedElement.h (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/FormAssociatedElement.h        2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/FormAssociatedElement.h   2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -62,7 +62,7 @@
</span><span class="cx"> 
</span><span class="cx">     // Override in derived classes to get the encoded name=value pair for submitting.
</span><span class="cx">     // Return true for a successful control (see HTML4-17.13.2).
</span><del>-    virtual bool appendFormData(DOMFormData&, bool) { return false; }
</del><ins>+    virtual bool appendFormData(DOMFormData&) { return false; }
</ins><span class="cx"> 
</span><span class="cx">     void formWillBeDestroyed();
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLButtonElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLButtonElement.cpp (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLButtonElement.cpp  2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/HTMLButtonElement.cpp     2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -208,7 +208,7 @@
</span><span class="cx">     m_isActivatedSubmit = flag;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-bool HTMLButtonElement::appendFormData(DOMFormData& formData, bool)
</del><ins>+bool HTMLButtonElement::appendFormData(DOMFormData& formData)
</ins><span class="cx"> {
</span><span class="cx">     if (m_type != SUBMIT || name().isEmpty() || !m_isActivatedSubmit)
</span><span class="cx">         return false;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLButtonElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLButtonElement.h (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLButtonElement.h    2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/HTMLButtonElement.h       2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -59,7 +59,7 @@
</span><span class="cx">     bool hasPresentationalHintsForAttribute(const QualifiedName&) const final;
</span><span class="cx">     void defaultEventHandler(Event&) final;
</span><span class="cx"> 
</span><del>-    bool appendFormData(DOMFormData&, bool) final;
</del><ins>+    bool appendFormData(DOMFormData&) final;
</ins><span class="cx"> 
</span><span class="cx">     bool isEnumeratable() const final { return true; }
</span><span class="cx">     bool supportLabels() const final { return true; }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFormControlElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFormControlElement.h (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFormControlElement.h       2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/HTMLFormControlElement.h  2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -86,7 +86,7 @@
</span><span class="cx"> 
</span><span class="cx">     // Override in derived classes to get the encoded name=value pair for submitting.
</span><span class="cx">     // Return true for a successful control (see HTML4-17.13.2).
</span><del>-    bool appendFormData(DOMFormData&, bool) override { return false; }
</del><ins>+    bool appendFormData(DOMFormData&) override { return false; }
</ins><span class="cx"> 
</span><span class="cx">     virtual bool isSuccessfulSubmitButton() const { return false; }
</span><span class="cx">     virtual bool isActivatedSubmit() const { return false; }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFormElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFormElement.cpp (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFormElement.cpp    2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/HTMLFormElement.cpp       2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -1008,7 +1008,7 @@
</span><span class="cx">     return equalIgnoringASCIICase(attributeWithoutSynchronization(autocompleteAttr), "off") ? off : on;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-RefPtr<DOMFormData> HTMLFormElement::constructEntryList(Ref<DOMFormData>&& domFormData, StringPairVector* formValues, IsMultipartForm isMultipartForm)
</del><ins>+RefPtr<DOMFormData> HTMLFormElement::constructEntryList(Ref<DOMFormData>&& domFormData, StringPairVector* formValues)
</ins><span class="cx"> {
</span><span class="cx">     // https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#constructing-form-data-set
</span><span class="cx">     ASSERT(isMainThread());
</span><span class="lines">@@ -1021,7 +1021,7 @@
</span><span class="cx">     for (auto& control : this->copyAssociatedElementsVector()) {
</span><span class="cx">         auto& element = control->asHTMLElement();
</span><span class="cx">         if (!element.isDisabledFormControl())
</span><del>-            control->appendFormData(domFormData.get(), isMultipartForm == IsMultipartForm::Yes);
</del><ins>+            control->appendFormData(domFormData.get());
</ins><span class="cx">         if (formValues && is<HTMLInputElement>(element)) {
</span><span class="cx">             auto& input = downcast<HTMLInputElement>(element);
</span><span class="cx">             if (input.isTextField()) {
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFormElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFormElement.h (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFormElement.h      2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/HTMLFormElement.h 2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -127,10 +127,8 @@
</span><span class="cx"> 
</span><span class="cx">     static HTMLFormElement* findClosestFormAncestor(const Element&);
</span><span class="cx">     
</span><del>-    enum class IsMultipartForm : bool { No, Yes };
</del><ins>+    RefPtr<DOMFormData> constructEntryList(Ref<DOMFormData>&&, StringPairVector*);
</ins><span class="cx">     
</span><del>-    RefPtr<DOMFormData> constructEntryList(Ref<DOMFormData>&&, StringPairVector*, IsMultipartForm);
-    
</del><span class="cx"> private:
</span><span class="cx">     HTMLFormElement(const QualifiedName&, Document&);
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLInputElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLInputElement.cpp (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLInputElement.cpp   2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/HTMLInputElement.cpp      2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -948,10 +948,10 @@
</span><span class="cx">     m_isActivatedSubmit = flag;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-bool HTMLInputElement::appendFormData(DOMFormData& formData, bool multipart)
</del><ins>+bool HTMLInputElement::appendFormData(DOMFormData& formData)
</ins><span class="cx"> {
</span><span class="cx">     Ref<InputType> protectedInputType(*m_inputType);
</span><del>-    return m_inputType->isFormDataAppendable() && m_inputType->appendFormData(formData, multipart);
</del><ins>+    return m_inputType->isFormDataAppendable() && m_inputType->appendFormData(formData);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void HTMLInputElement::reset()
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLInputElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLInputElement.h (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLInputElement.h     2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/HTMLInputElement.h        2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -406,7 +406,7 @@
</span><span class="cx"> 
</span><span class="cx">     void copyNonAttributePropertiesFromElement(const Element&) final;
</span><span class="cx"> 
</span><del>-    bool appendFormData(DOMFormData&, bool) final;
</del><ins>+    bool appendFormData(DOMFormData&) final;
</ins><span class="cx"> 
</span><span class="cx">     bool isSuccessfulSubmitButton() const final;
</span><span class="cx">     bool matchesDefaultPseudoClass() const final;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLKeygenElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLKeygenElement.cpp (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLKeygenElement.cpp  2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/HTMLKeygenElement.cpp     2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -117,7 +117,7 @@
</span><span class="cx">     return isKeytypeRSA() ? "rsa"_s : emptyString();
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-bool HTMLKeygenElement::appendFormData(DOMFormData& formData, bool)
</del><ins>+bool HTMLKeygenElement::appendFormData(DOMFormData& formData)
</ins><span class="cx"> {
</span><span class="cx">     // Only RSA is supported at this time.
</span><span class="cx">     if (!isKeytypeRSA())
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLKeygenElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLKeygenElement.h (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLKeygenElement.h    2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/HTMLKeygenElement.h       2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -45,7 +45,7 @@
</span><span class="cx"> 
</span><span class="cx">     void parseAttribute(const QualifiedName&, const AtomString&) final;
</span><span class="cx"> 
</span><del>-    bool appendFormData(DOMFormData&, bool) final;
</del><ins>+    bool appendFormData(DOMFormData&) final;
</ins><span class="cx">     const AtomString& formControlType() const final;
</span><span class="cx">     bool isOptionalFormControl() const final { return false; }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLObjectElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLObjectElement.cpp (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLObjectElement.cpp  2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/HTMLObjectElement.cpp     2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -462,7 +462,7 @@
</span><span class="cx">     HTMLPlugInImageElement::didMoveToNewDocument(oldDocument, newDocument);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-bool HTMLObjectElement::appendFormData(DOMFormData& formData, bool)
</del><ins>+bool HTMLObjectElement::appendFormData(DOMFormData& formData)
</ins><span class="cx"> {
</span><span class="cx">     if (name().isEmpty())
</span><span class="cx">         return false;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLObjectElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLObjectElement.h (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLObjectElement.h    2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/HTMLObjectElement.h       2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -99,7 +99,7 @@
</span><span class="cx">     bool isFormControlElement() const final { return false; }
</span><span class="cx"> 
</span><span class="cx">     bool isEnumeratable() const final { return true; }
</span><del>-    bool appendFormData(DOMFormData&, bool) final;
</del><ins>+    bool appendFormData(DOMFormData&) final;
</ins><span class="cx"> 
</span><span class="cx">     bool canContainRangeEndPoint() const final;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLSelectElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLSelectElement.cpp (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLSelectElement.cpp  2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/HTMLSelectElement.cpp     2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -1045,7 +1045,7 @@
</span><span class="cx">         invalidateStyleAndRenderersForSubtree();
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-bool HTMLSelectElement::appendFormData(DOMFormData& formData, bool)
</del><ins>+bool HTMLSelectElement::appendFormData(DOMFormData& formData)
</ins><span class="cx"> {
</span><span class="cx">     const AtomString& name = this->name();
</span><span class="cx">     if (name.isEmpty())
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLSelectElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLSelectElement.h (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLSelectElement.h    2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/HTMLSelectElement.h       2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -134,7 +134,7 @@
</span><span class="cx"> 
</span><span class="cx">     bool childShouldCreateRenderer(const Node&) const final;
</span><span class="cx">     RenderPtr<RenderElement> createElementRenderer(RenderStyle&&, const RenderTreePosition&) final;
</span><del>-    bool appendFormData(DOMFormData&, bool) final;
</del><ins>+    bool appendFormData(DOMFormData&) final;
</ins><span class="cx"> 
</span><span class="cx">     void reset() final;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTextAreaElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTextAreaElement.cpp (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTextAreaElement.cpp        2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/HTMLTextAreaElement.cpp   2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -222,7 +222,7 @@
</span><span class="cx">     return createRenderer<RenderTextControlMultiLine>(*this, WTFMove(style));
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-bool HTMLTextAreaElement::appendFormData(DOMFormData& formData, bool)
</del><ins>+bool HTMLTextAreaElement::appendFormData(DOMFormData& formData)
</ins><span class="cx"> {
</span><span class="cx">     if (name().isEmpty())
</span><span class="cx">         return false;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTextAreaElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTextAreaElement.h (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTextAreaElement.h  2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/HTMLTextAreaElement.h     2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -114,7 +114,7 @@
</span><span class="cx">     bool hasPresentationalHintsForAttribute(const QualifiedName&) const final;
</span><span class="cx">     void collectPresentationalHintsForAttribute(const QualifiedName&, const AtomString&, MutableStyleProperties&) final;
</span><span class="cx">     RenderPtr<RenderElement> createElementRenderer(RenderStyle&&, const RenderTreePosition&) final;
</span><del>-    bool appendFormData(DOMFormData&, bool) final;
</del><ins>+    bool appendFormData(DOMFormData&) final;
</ins><span class="cx">     void reset() final;
</span><span class="cx">     bool hasCustomFocusLogic() const final;
</span><span class="cx">     int defaultTabIndex() const final;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHiddenInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HiddenInputType.cpp (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HiddenInputType.cpp    2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/HiddenInputType.cpp       2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -89,7 +89,7 @@
</span><span class="cx">     element()->setAttributeWithoutSynchronization(valueAttr, sanitizedValue);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-bool HiddenInputType::appendFormData(DOMFormData& formData, bool isMultipartForm) const
</del><ins>+bool HiddenInputType::appendFormData(DOMFormData& formData) const
</ins><span class="cx"> {
</span><span class="cx">     ASSERT(element());
</span><span class="cx">     auto name = element()->name();
</span><span class="lines">@@ -98,7 +98,7 @@
</span><span class="cx">         formData.append(name, String { formData.encoding().name() });
</span><span class="cx">         return true;
</span><span class="cx">     }
</span><del>-    return InputType::appendFormData(formData, isMultipartForm);
</del><ins>+    return InputType::appendFormData(formData);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> bool HiddenInputType::shouldRespectHeightAndWidthAttributes()
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHiddenInputTypeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HiddenInputType.h (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HiddenInputType.h      2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/HiddenInputType.h 2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -49,7 +49,7 @@
</span><span class="cx">     bool storesValueSeparateFromAttribute() override;
</span><span class="cx">     bool shouldRespectHeightAndWidthAttributes() override;
</span><span class="cx">     void setValue(const String&, bool, TextFieldEventBehavior) override;
</span><del>-    bool appendFormData(DOMFormData&, bool) const override;
</del><ins>+    bool appendFormData(DOMFormData&) const override;
</ins><span class="cx"> };
</span><span class="cx"> 
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlImageInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/ImageInputType.cpp (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/ImageInputType.cpp     2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/ImageInputType.cpp        2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -55,7 +55,7 @@
</span><span class="cx">     return true;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-bool ImageInputType::appendFormData(DOMFormData& formData, bool) const
</del><ins>+bool ImageInputType::appendFormData(DOMFormData& formData) const
</ins><span class="cx"> {
</span><span class="cx">     ASSERT(element());
</span><span class="cx">     if (!element()->isActivatedSubmit())
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlImageInputTypeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/ImageInputType.h (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/ImageInputType.h       2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/ImageInputType.h  2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -45,7 +45,7 @@
</span><span class="cx"> private:
</span><span class="cx">     const AtomString& formControlType() const final;
</span><span class="cx">     bool isFormDataAppendable() const final;
</span><del>-    bool appendFormData(DOMFormData&, bool) const final;
</del><ins>+    bool appendFormData(DOMFormData&) const final;
</ins><span class="cx">     RenderPtr<RenderElement> createInputRenderer(RenderStyle&&) final;
</span><span class="cx">     void handleDOMActivateEvent(Event&) final;
</span><span class="cx">     void attributeChanged(const QualifiedName&) final;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/InputType.cpp (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/InputType.cpp  2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/InputType.cpp     2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -196,7 +196,7 @@
</span><span class="cx">     return !element()->name().isEmpty();
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-bool InputType::appendFormData(DOMFormData& formData, bool) const
</del><ins>+bool InputType::appendFormData(DOMFormData& formData) const
</ins><span class="cx"> {
</span><span class="cx">     ASSERT(element());
</span><span class="cx">     // Always successful.
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlInputTypeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/InputType.h (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/InputType.h    2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/InputType.h       2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -213,7 +213,7 @@
</span><span class="cx">     virtual FormControlState saveFormControlState() const;
</span><span class="cx">     virtual void restoreFormControlState(const FormControlState&);
</span><span class="cx">     virtual bool isFormDataAppendable() const;
</span><del>-    virtual bool appendFormData(DOMFormData&, bool multipart) const;
</del><ins>+    virtual bool appendFormData(DOMFormData&) const;
</ins><span class="cx"> 
</span><span class="cx">     // DOM property functions.
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlSubmitInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/SubmitInputType.cpp (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/SubmitInputType.cpp    2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/SubmitInputType.cpp       2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx">     return InputTypeNames::submit();
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-bool SubmitInputType::appendFormData(DOMFormData& formData, bool) const
</del><ins>+bool SubmitInputType::appendFormData(DOMFormData& formData) const
</ins><span class="cx"> {
</span><span class="cx">     ASSERT(element());
</span><span class="cx">     if (!element()->isActivatedSubmit())
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlSubmitInputTypeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/SubmitInputType.h (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/SubmitInputType.h      2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/SubmitInputType.h 2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx"> 
</span><span class="cx"> private:
</span><span class="cx">     const AtomString& formControlType() const override;
</span><del>-    bool appendFormData(DOMFormData&, bool) const override;
</del><ins>+    bool appendFormData(DOMFormData&) const override;
</ins><span class="cx">     bool supportsRequired() const override;
</span><span class="cx">     void handleDOMActivateEvent(Event&) override;
</span><span class="cx">     bool canBeSuccessfulSubmitButton() override;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlTextFieldInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/TextFieldInputType.cpp (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/TextFieldInputType.cpp 2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/TextFieldInputType.cpp    2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -634,9 +634,9 @@
</span><span class="cx">     m_placeholder->setInnerText(placeholderText);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-bool TextFieldInputType::appendFormData(DOMFormData& formData, bool multipart) const
</del><ins>+bool TextFieldInputType::appendFormData(DOMFormData& formData) const
</ins><span class="cx"> {
</span><del>-    InputType::appendFormData(formData, multipart);
</del><ins>+    InputType::appendFormData(formData);
</ins><span class="cx">     ASSERT(element());
</span><span class="cx">     auto& dirnameAttrValue = element()->attributeWithoutSynchronization(dirnameAttr);
</span><span class="cx">     if (!dirnameAttrValue.isNull())
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlTextFieldInputTypeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/TextFieldInputType.h (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/TextFieldInputType.h   2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/html/TextFieldInputType.h      2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -98,7 +98,7 @@
</span><span class="cx">     bool shouldRespectListAttribute() override;
</span><span class="cx">     HTMLElement* placeholderElement() const final;
</span><span class="cx">     void updatePlaceholderText() final;
</span><del>-    bool appendFormData(DOMFormData&, bool multipart) const final;
</del><ins>+    bool appendFormData(DOMFormData&) const final;
</ins><span class="cx">     void subtreeHasChanged() final;
</span><span class="cx">     void capsLockStateMayHaveChanged() final;
</span><span class="cx">     void updateAutoFillButton() final;
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderFormSubmissioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/FormSubmission.cpp (286446 => 286447)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/FormSubmission.cpp   2021-12-02 21:04:38 UTC (rev 286446)
+++ trunk/Source/WebCore/loader/FormSubmission.cpp      2021-12-02 21:13:02 UTC (rev 286447)
</span><span class="lines">@@ -212,7 +212,7 @@
</span><span class="cx">     auto domFormData = DOMFormData::create(dataEncoding.encodingForFormSubmissionOrURLParsing());
</span><span class="cx">     StringPairVector formValues;
</span><span class="cx"> 
</span><del>-    auto result = form.constructEntryList(WTFMove(domFormData), &formValues, isMultiPartForm ? HTMLFormElement::IsMultipartForm::Yes : HTMLFormElement::IsMultipartForm::No);
</del><ins>+    auto result = form.constructEntryList(WTFMove(domFormData), &formValues);
</ins><span class="cx">     RELEASE_ASSERT(result);
</span><span class="cx">     domFormData = result.releaseNonNull();
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>