<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[286300] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/286300">286300</a></dd>
<dt>Author</dt> <dd>youenn@apple.com</dd>
<dt>Date</dt> <dd>2021-11-30 08:32:15 -0800 (Tue, 30 Nov 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Move TransformStreamAPIEnabled flag to Settings
https://bugs.webkit.org/show_bug.cgi?id=233524

Reviewed by Chris Dumez.

Source/WebCore:

Covered by existing tests.

* Modules/streams/TransformStream.idl:
* Modules/streams/TransformStreamDefaultController.idl:
* dom/TextDecoderStream.idl:
* dom/TextDecoderStreamDecoder.idl:
* dom/TextEncoderStream.idl:
* dom/TextEncoderStreamEncoder.idl:
* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::readableByteStreamAPIEnabled const):
(WebCore::RuntimeEnabledFeatures::setTransformStreamAPIEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::transformStreamAPIEnabled const): Deleted.

Source/WTF:

* Scripts/Preferences/WebPreferencesExperimental.yaml:

LayoutTests:

* platform/win/streams/reference-implementation/transform-stream-errors-expected.txt: Removed.
* platform/win/streams/reference-implementation/transform-stream-expected.txt: Removed.
* platform/wincairo/streams/reference-implementation/transform-stream-errors-expected.txt: Removed.
* platform/wincairo/streams/reference-implementation/transform-stream-expected.txt: Removed.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFScriptsPreferencesWebPreferencesExperimentalyaml">trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesstreamsTransformStreamidl">trunk/Source/WebCore/Modules/streams/TransformStream.idl</a></li>
<li><a href="#trunkSourceWebCoreModulesstreamsTransformStreamDefaultControlleridl">trunk/Source/WebCore/Modules/streams/TransformStreamDefaultController.idl</a></li>
<li><a href="#trunkSourceWebCoredomTextDecoderStreamidl">trunk/Source/WebCore/dom/TextDecoderStream.idl</a></li>
<li><a href="#trunkSourceWebCoredomTextDecoderStreamDecoderidl">trunk/Source/WebCore/dom/TextDecoderStreamDecoder.idl</a></li>
<li><a href="#trunkSourceWebCoredomTextEncoderStreamidl">trunk/Source/WebCore/dom/TextEncoderStream.idl</a></li>
<li><a href="#trunkSourceWebCoredomTextEncoderStreamEncoderidl">trunk/Source/WebCore/dom/TextEncoderStreamEncoder.idl</a></li>
<li><a href="#trunkSourceWebCorepageRuntimeEnabledFeaturesh">trunk/Source/WebCore/page/RuntimeEnabledFeatures.h</a></li>
</ul>

<h3>Removed Paths</h3>
<ul>
<li>trunk/LayoutTests/platform/win/streams/</li>
<li>trunk/LayoutTests/platform/wincairo/streams/</li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (286299 => 286300)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2021-11-30 16:27:07 UTC (rev 286299)
+++ trunk/LayoutTests/ChangeLog 2021-11-30 16:32:15 UTC (rev 286300)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2021-11-30  Youenn Fablet  <youenn@apple.com>
</span><span class="cx"> 
</span><ins>+        Move TransformStreamAPIEnabled flag to Settings
+        https://bugs.webkit.org/show_bug.cgi?id=233524
+
+        Reviewed by Chris Dumez.
+
+        * platform/win/streams/reference-implementation/transform-stream-errors-expected.txt: Removed.
+        * platform/win/streams/reference-implementation/transform-stream-expected.txt: Removed.
+        * platform/wincairo/streams/reference-implementation/transform-stream-errors-expected.txt: Removed.
+        * platform/wincairo/streams/reference-implementation/transform-stream-expected.txt: Removed.
+
+2021-11-30  Youenn Fablet  <youenn@apple.com>
+
</ins><span class="cx">         ServiceWorkerContainer does not respond well to network process crash
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=233626
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (286299 => 286300)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog       2021-11-30 16:27:07 UTC (rev 286299)
+++ trunk/Source/WTF/ChangeLog  2021-11-30 16:32:15 UTC (rev 286300)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2021-11-30  Youenn Fablet  <youenn@apple.com>
+
+        Move TransformStreamAPIEnabled flag to Settings
+        https://bugs.webkit.org/show_bug.cgi?id=233524
+
+        Reviewed by Chris Dumez.
+
+        * Scripts/Preferences/WebPreferencesExperimental.yaml:
+
</ins><span class="cx"> 2021-11-29  Chris Dumez  <cdumez@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Add initial implementation for the Web Lock API
</span></span></pre></div>
<a id="trunkSourceWTFScriptsPreferencesWebPreferencesExperimentalyaml"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (286299 => 286300)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml     2021-11-30 16:27:07 UTC (rev 286299)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml        2021-11-30 16:32:15 UTC (rev 286300)
</span><span class="lines">@@ -1334,8 +1334,9 @@
</span><span class="cx">   type: bool
</span><span class="cx">   humanReadableName: "TransformStream API"
</span><span class="cx">   humanReadableDescription: "Enable Transform Stream API"
</span><del>-  webcoreBinding: RuntimeEnabledFeatures
</del><span class="cx">   defaultValue:
</span><ins>+    WebCore:
+      default: true
</ins><span class="cx">     WebKitLegacy:
</span><span class="cx">       default: true
</span><span class="cx">     WebKit:
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (286299 => 286300)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2021-11-30 16:27:07 UTC (rev 286299)
+++ trunk/Source/WebCore/ChangeLog      2021-11-30 16:32:15 UTC (rev 286300)
</span><span class="lines">@@ -1,5 +1,25 @@
</span><span class="cx"> 2021-11-30  Youenn Fablet  <youenn@apple.com>
</span><span class="cx"> 
</span><ins>+        Move TransformStreamAPIEnabled flag to Settings
+        https://bugs.webkit.org/show_bug.cgi?id=233524
+
+        Reviewed by Chris Dumez.
+
+        Covered by existing tests.
+
+        * Modules/streams/TransformStream.idl:
+        * Modules/streams/TransformStreamDefaultController.idl:
+        * dom/TextDecoderStream.idl:
+        * dom/TextDecoderStreamDecoder.idl:
+        * dom/TextEncoderStream.idl:
+        * dom/TextEncoderStreamEncoder.idl:
+        * page/RuntimeEnabledFeatures.h:
+        (WebCore::RuntimeEnabledFeatures::readableByteStreamAPIEnabled const):
+        (WebCore::RuntimeEnabledFeatures::setTransformStreamAPIEnabled): Deleted.
+        (WebCore::RuntimeEnabledFeatures::transformStreamAPIEnabled const): Deleted.
+
+2021-11-30  Youenn Fablet  <youenn@apple.com>
+
</ins><span class="cx">         ServiceWorkerContainer does not respond well to network process crash
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=233626
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesstreamsTransformStreamidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/streams/TransformStream.idl (286299 => 286300)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/streams/TransformStream.idl 2021-11-30 16:27:07 UTC (rev 286299)
+++ trunk/Source/WebCore/Modules/streams/TransformStream.idl    2021-11-30 16:32:15 UTC (rev 286300)
</span><span class="lines">@@ -24,7 +24,7 @@
</span><span class="cx">  */
</span><span class="cx"> 
</span><span class="cx"> [
</span><del>-    EnabledAtRuntime=TransformStreamAPIEnabled,
</del><ins>+    EnabledBySetting=TransformStreamAPIEnabled,
</ins><span class="cx">     Exposed=(Window,Worker),
</span><span class="cx">     JSBuiltin,
</span><span class="cx">     PrivateIdentifier,
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesstreamsTransformStreamDefaultControlleridl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/streams/TransformStreamDefaultController.idl (286299 => 286300)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/streams/TransformStreamDefaultController.idl        2021-11-30 16:27:07 UTC (rev 286299)
+++ trunk/Source/WebCore/Modules/streams/TransformStreamDefaultController.idl   2021-11-30 16:32:15 UTC (rev 286300)
</span><span class="lines">@@ -24,7 +24,7 @@
</span><span class="cx">  */
</span><span class="cx"> 
</span><span class="cx"> [
</span><del>-    EnabledAtRuntime=TransformStreamAPIEnabled,
</del><ins>+    EnabledBySetting=TransformStreamAPIEnabled,
</ins><span class="cx">     Exposed=(Window,Worker),
</span><span class="cx">     JSBuiltin,
</span><span class="cx">     PrivateIdentifier,
</span></span></pre></div>
<a id="trunkSourceWebCoredomTextDecoderStreamidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/TextDecoderStream.idl (286299 => 286300)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/TextDecoderStream.idl   2021-11-30 16:27:07 UTC (rev 286299)
+++ trunk/Source/WebCore/dom/TextDecoderStream.idl      2021-11-30 16:32:15 UTC (rev 286300)
</span><span class="lines">@@ -24,7 +24,7 @@
</span><span class="cx">  */
</span><span class="cx"> 
</span><span class="cx"> [
</span><del>-    EnabledAtRuntime=TransformStreamAPIEnabled,
</del><ins>+    EnabledBySetting=TransformStreamAPIEnabled,
</ins><span class="cx">     Exposed=(Window,Worker),
</span><span class="cx">     JSBuiltin,
</span><span class="cx"> ] interface TextDecoderStream {
</span></span></pre></div>
<a id="trunkSourceWebCoredomTextDecoderStreamDecoderidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/TextDecoderStreamDecoder.idl (286299 => 286300)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/TextDecoderStreamDecoder.idl    2021-11-30 16:27:07 UTC (rev 286299)
+++ trunk/Source/WebCore/dom/TextDecoderStreamDecoder.idl       2021-11-30 16:32:15 UTC (rev 286300)
</span><span class="lines">@@ -24,7 +24,7 @@
</span><span class="cx">  */
</span><span class="cx"> 
</span><span class="cx"> [
</span><del>-    EnabledAtRuntime=TransformStreamAPIEnabled,
</del><ins>+    EnabledBySetting=TransformStreamAPIEnabled,
</ins><span class="cx">     Exposed=(Window,Worker),
</span><span class="cx">     ImplementationLacksVTable,
</span><span class="cx">     PrivateIdentifier,
</span></span></pre></div>
<a id="trunkSourceWebCoredomTextEncoderStreamidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/TextEncoderStream.idl (286299 => 286300)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/TextEncoderStream.idl   2021-11-30 16:27:07 UTC (rev 286299)
+++ trunk/Source/WebCore/dom/TextEncoderStream.idl      2021-11-30 16:32:15 UTC (rev 286300)
</span><span class="lines">@@ -24,7 +24,7 @@
</span><span class="cx"> */
</span><span class="cx"> 
</span><span class="cx"> [
</span><del>-    EnabledAtRuntime=TransformStreamAPIEnabled,
</del><ins>+    EnabledBySetting=TransformStreamAPIEnabled,
</ins><span class="cx">     Exposed=(Window,Worker),
</span><span class="cx">     JSBuiltin,
</span><span class="cx"> ] interface TextEncoderStream {
</span></span></pre></div>
<a id="trunkSourceWebCoredomTextEncoderStreamEncoderidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/TextEncoderStreamEncoder.idl (286299 => 286300)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/TextEncoderStreamEncoder.idl    2021-11-30 16:27:07 UTC (rev 286299)
+++ trunk/Source/WebCore/dom/TextEncoderStreamEncoder.idl       2021-11-30 16:32:15 UTC (rev 286300)
</span><span class="lines">@@ -24,7 +24,7 @@
</span><span class="cx">  */
</span><span class="cx"> 
</span><span class="cx"> [
</span><del>-    EnabledAtRuntime=TransformStreamAPIEnabled,
</del><ins>+    EnabledBySetting=TransformStreamAPIEnabled,
</ins><span class="cx">     Exposed=(Window,Worker),
</span><span class="cx">     ImplementationLacksVTable,
</span><span class="cx">     PrivateIdentifier,
</span></span></pre></div>
<a id="trunkSourceWebCorepageRuntimeEnabledFeaturesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.h (286299 => 286300)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.h       2021-11-30 16:27:07 UTC (rev 286299)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.h  2021-11-30 16:32:15 UTC (rev 286300)
</span><span class="lines">@@ -167,8 +167,6 @@
</span><span class="cx"> 
</span><span class="cx">     void setReadableByteStreamAPIEnabled(bool isEnabled) { m_isReadableByteStreamAPIEnabled = isEnabled; }
</span><span class="cx">     bool readableByteStreamAPIEnabled() const { return m_isReadableByteStreamAPIEnabled; }
</span><del>-    void setTransformStreamAPIEnabled(bool isEnabled) { m_isTransformStreamAPIEnabled = isEnabled; }
-    bool transformStreamAPIEnabled() const { return m_isTransformStreamAPIEnabled; }
</del><span class="cx"> 
</span><span class="cx"> #if ENABLE(SERVICE_WORKER)
</span><span class="cx">     bool pushAPIEnabled() const { return m_pushAPIEnabled; }
</span><span class="lines">@@ -332,7 +330,6 @@
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><span class="cx">     bool m_isReadableByteStreamAPIEnabled { false };
</span><del>-    bool m_isTransformStreamAPIEnabled { false };
</del><span class="cx"> 
</span><span class="cx"> #if ENABLE(SERVICE_WORKER)
</span><span class="cx">     bool m_pushAPIEnabled { false };
</span></span></pre>
</div>
</div>

</body>
</html>